murblanc merged PR #2207:
URL: https://github.com/apache/solr/pull/2207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
murblanc commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1494768851
##
solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java:
##
@@ -120,9 +120,22 @@ public enum Type {
*/
PULL(false, false, true, CollectionAdminParams.
murblanc commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1494762307
##
solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java:
##
@@ -120,9 +120,22 @@ public enum Type {
*/
PULL(false, false, true, CollectionAdminParams.
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489895570
##
solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java:
##
@@ -104,27 +104,35 @@ public enum Type {
* support NRT (soft commits) and RTG. Any {@link Type#NRT
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489888413
##
solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java:
##
@@ -104,27 +104,35 @@ public enum Type {
* support NRT (soft commits) and RTG. Any {@link Type#NRT
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489886455
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -2400,15 +2402,15 @@ public void rejoinShardLeaderElection(SolrParams
params) {
try (SolrCore
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489634706
##
solr/core/src/java/org/apache/solr/update/UpdateHandler.java:
##
@@ -116,10 +116,13 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog) {
parseEventListeners
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489287486
##
solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java:
##
@@ -104,27 +104,35 @@ public enum Type {
* support NRT (soft commits) and RTG. Any {@link Type#NRT
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489285471
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2050,15 +2050,13 @@ public void reload(String name, UUID coreId) {
if (docCollection != null)
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489280963
##
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##
@@ -583,7 +587,7 @@ public final void doSyncOrReplicateRecovery(SolrCore core)
throws Exception {
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489279539
##
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##
@@ -417,8 +419,10 @@ private final void doReplicateOnlyRecovery(SolrCore core)
throws InterruptedExce
murblanc commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1486781194
##
solr/core/src/java/org/apache/solr/update/UpdateHandler.java:
##
@@ -116,10 +116,13 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog) {
parseEventListen
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1458630873
##
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##
@@ -1801,6 +1801,8 @@ private static Long readIntervalNs(String interval) {
// in case of TLOG r
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1458617284
##
solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContext.java:
##
@@ -270,9 +270,11 @@ void runLeaderProcess(boolean weAreReplacement, int
pauseBeforeStart)
pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1458616885
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -88,31 +87,9 @@ public void startReplication(boolean switchTransactionLog) {
log.info("Wil
pvcnt opened a new pull request, #2207:
URL: https://github.com/apache/solr/pull/2207
https://issues.apache.org/jira/browse/SOLR-16995
# Description
I am resuming refactoring started earlier (#1928, #1981, #2039) with the
goal of simplifying/centralising code relate
16 matches
Mail list logo
