pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1458630873
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -1801,6 +1801,8 @@ private static Long readIntervalNs(String interval) {
// in case of TLOG replica, if leaderVersion = zero, don't do commit
// otherwise updates from current tlog won't copied over properly to the new
tlog, leading to data
// loss
+ // don't commit on leader version zero for PULL replicas as PULL should only
get its index
+ // state from leader
public static final String SKIP_COMMIT_ON_LEADER_VERSION_ZERO =
"skipCommitOnLeaderVersionZero";
Review Comment:
I'm a bit dubious over how this parameter is used overall. When replicating
from the leader, its value is always true. When recovering, it's true only for
TLOG replicas (does it mean that the reason for setting it to true when
replicating does not hold when recovering?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
