pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489279539
##########
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##########
@@ -417,8 +419,10 @@ private final void doReplicateOnlyRecovery(SolrCore core)
throws InterruptedExce
log.error("Error while trying to recover. core={}", coreName, e);
} finally {
if (successfulRecovery) {
- log.info("Restarting background replicate from leader process");
- zkController.startReplicationFromLeader(coreName, false);
+ if (replicaType.replicateFromLeader) {
Review Comment:
No, because this method is only called for PULL replicas. But adding this as
a safeguard nonetheless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
