Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-07-03 Thread via GitHub
github-actions[bot] commented on PR #2203: URL: https://github.com/apache/solr/pull/2203#issuecomment-2207574026 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #2203: URL: https://github.com/apache/solr/pull/2203#issuecomment-2071145600 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-02-20 Thread via GitHub
pvcnt commented on code in PR #2203: URL: https://github.com/apache/solr/pull/2203#discussion_r1496072172 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -104,27 +104,35 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-02-20 Thread via GitHub
pvcnt commented on code in PR #2203: URL: https://github.com/apache/solr/pull/2203#discussion_r1496062478 ## solr/core/src/java/org/apache/solr/handler/component/CloudReplicaSource.java: ## @@ -170,10 +170,9 @@ private List findReplicas( .filter(replica -> replica

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-02-19 Thread via GitHub
murblanc commented on code in PR #2203: URL: https://github.com/apache/solr/pull/2203#discussion_r1494802432 ## solr/core/src/java/org/apache/solr/handler/component/CloudReplicaSource.java: ## @@ -288,8 +287,8 @@ public Builder params(SolrParams params) { return this;

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-01-19 Thread via GitHub
pvcnt commented on code in PR #2203: URL: https://github.com/apache/solr/pull/2203#discussion_r1459038206 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -999,36 +999,6 @@ public static String getShardLeadersElectPath(String collection, S

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-01-19 Thread via GitHub
pvcnt commented on code in PR #2203: URL: https://github.com/apache/solr/pull/2203#discussion_r1459033565 ## solr/core/src/java/org/apache/solr/handler/component/CloudReplicaSource.java: ## @@ -170,10 +170,9 @@ private List findReplicas( .filter(replica -> replica

Re: [PR] SOLR-16995: Configure follower behaviour for each replica type [solr]

2024-01-19 Thread via GitHub
pvcnt commented on code in PR #2203: URL: https://github.com/apache/solr/pull/2203#discussion_r1459031840 ## solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java: ## @@ -72,6 +81,7 @@ public SyncStrategy(CoreContainer cc) { client = updateShardHandler.getDefaultHttpCl