Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

janhoy merged PR #1919: URL: https://github.com/apache/solr/pull/1919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1386590546 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java: ## @@ -111,43 +199,82 @@ public static String toErrorMessage(List circuitBreakerList

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

cpoerschke commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1386555317 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java: ## @@ -111,43 +199,82 @@ public static String toErrorMessage(List circuitBreaker

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1385683982 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -33,39 +35,47 @@ * We depend on OperatingSystemMXBean which does not allow a confi

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1385670500 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java: ## @@ -111,43 +199,82 @@ public static String toErrorMessage(List circuitBreakerList

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1385668610 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -33,39 +35,47 @@ * We depend on OperatingSystemMXBean which does not allow a confi

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

cpoerschke commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1385267122 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -33,39 +35,47 @@ * We depend on OperatingSystemMXBean which does not allow a c

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

janhoy commented on PR #1919: URL: https://github.com/apache/solr/pull/1919#issuecomment-1798650319 I think this is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c