janhoy commented on code in PR #1919:
URL: https://github.com/apache/solr/pull/1919#discussion_r1386590546
##########
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java:
##########
@@ -111,43 +199,82 @@ public static String toErrorMessage(List<CircuitBreaker>
circuitBreakerList) {
}
public boolean isEnabled(SolrRequestType requestType) {
- return circuitBreakerMap.containsKey(requestType);
+ return circuitBreakerMap.containsKey(requestType)
+ || globalCircuitBreakerMap.containsKey(requestType);
Review Comment:
Hehe. This map will contain two request type enums `QUERY` and `UPDATE`, so
they should be super fast anyway. And we don't have reason to believe that one
is more used than the other at this point. So I'll leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
