cpoerschke commented on code in PR #1919:
URL: https://github.com/apache/solr/pull/1919#discussion_r1386555317
##########
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java:
##########
@@ -111,43 +199,82 @@ public static String toErrorMessage(List<CircuitBreaker>
circuitBreakerList) {
}
public boolean isEnabled(SolrRequestType requestType) {
- return circuitBreakerMap.containsKey(requestType);
+ return circuitBreakerMap.containsKey(requestType)
+ || globalCircuitBreakerMap.containsKey(requestType);
Review Comment:
If (and that is an if) one assumes that global circuit breakers would be
more commonly configured (since they are easier to configure) than per-core
ones then a successful lookup in the first map would save a lookup attempt in
the second map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
