Re: [PR] SOLR-16577: Always log core load issues [solr]

2024-05-10 Thread via GitHub
mkgudla commented on PR #1221: URL: https://github.com/apache/solr/pull/1221#issuecomment-2104613062 After upgrading to 9.5, we ran into issues while loading the Solr Cores. We got interrupted exceptions and the cores didn't get loaded completely. Later we saw that in this fix,

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-08 Thread via GitHub
dsmiley merged PR #1221: URL: https://github.com/apache/solr/pull/1221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-08 Thread via GitHub
dsmiley commented on PR #1221: URL: https://github.com/apache/solr/pull/1221#issuecomment-1847186357 @risdenk I think your concerns have been addressed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-06 Thread via GitHub
heythm commented on PR #1221: URL: https://github.com/apache/solr/pull/1221#issuecomment-1843222328 Sorry for the force-push, I did it to amend a commit message. It wasn't a good idea. @dsmiley knows about it. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-06 Thread via GitHub
heythm commented on code in PR #1221: URL: https://github.com/apache/solr/pull/1221#discussion_r1417168401 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -973,29 +969,31 @@ public void load() { solrCores.markCoreAsLoading(cd); }

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-06 Thread via GitHub
heythm commented on code in PR #1221: URL: https://github.com/apache/solr/pull/1221#discussion_r1417144757 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -1004,24 +1002,9 @@ public void load() { backgroundCloser.start(); } finally { - if

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-05 Thread via GitHub
dsmiley commented on PR #1221: URL: https://github.com/apache/solr/pull/1221#issuecomment-1841829670 @heythm , for a very old PR, first get it up to date with main (merge main into this) *then* update CHANGES.txt. Doing CHANGES.txt too early is no fun merging. Also remember there is a bun

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-05 Thread via GitHub
dsmiley commented on code in PR #1221: URL: https://github.com/apache/solr/pull/1221#discussion_r1416431432 ## solr/CHANGES.txt: ## @@ -160,7 +160,7 @@ Other Changes SOLR-16575: splitshard should honour createNodeSet (noble) -* SOLR-16577: Always log core load issues (Hayth