heythm commented on code in PR #1221:
URL: https://github.com/apache/solr/pull/1221#discussion_r1417168401
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -973,29 +969,31 @@ public void load() {
solrCores.markCoreAsLoading(cd);
}
if (cd.isLoadOnStartup()) {
- futures.add(
- coreLoadExecutor.submit(
- () -> {
- SolrCore core;
- try {
- if (zkSys.getZkController() != null) {
-
zkSys.getZkController().throwErrorIfReplicaReplaced(cd);
- }
- solrCores.waitAddPendingCoreOps(cd.getName());
- core = createFromDescriptor(cd, false, false);
- } finally {
- solrCores.removeFromPendingOps(cd.getName());
- if (asyncSolrCoreLoad) {
- solrCores.markCoreAsNotLoading(cd);
- }
- }
- try {
- zkSys.registerInZk(core, true, false);
- } catch (RuntimeException e) {
- SolrException.log(log, "Error registering SolrCore", e);
- }
- return core;
- }));
+ coreLoadExecutor.submit(
Review Comment:
`coreContainerWorkExecutor` is for async core loadings
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -973,29 +969,31 @@ public void load() {
solrCores.markCoreAsLoading(cd);
}
if (cd.isLoadOnStartup()) {
- futures.add(
- coreLoadExecutor.submit(
- () -> {
- SolrCore core;
- try {
- if (zkSys.getZkController() != null) {
-
zkSys.getZkController().throwErrorIfReplicaReplaced(cd);
- }
- solrCores.waitAddPendingCoreOps(cd.getName());
- core = createFromDescriptor(cd, false, false);
- } finally {
- solrCores.removeFromPendingOps(cd.getName());
- if (asyncSolrCoreLoad) {
- solrCores.markCoreAsNotLoading(cd);
- }
- }
- try {
- zkSys.registerInZk(core, true, false);
- } catch (RuntimeException e) {
- SolrException.log(log, "Error registering SolrCore", e);
- }
- return core;
- }));
+ coreLoadExecutor.submit(
Review Comment:
`coreContainerWorkExecutor` is for async cores loadings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
