heythm commented on code in PR #1221:
URL: https://github.com/apache/solr/pull/1221#discussion_r1417144757
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -1004,24 +1002,9 @@ public void load() {
backgroundCloser.start();
} finally {
- if (asyncSolrCoreLoad && futures != null) {
-
+ if (asyncSolrCoreLoad) {
coreContainerWorkExecutor.submit(
- () -> {
- try {
- for (Future<SolrCore> future : futures) {
- try {
- future.get();
- } catch (InterruptedException e) {
- Thread.currentThread().interrupt();
- } catch (ExecutionException e) {
- log.error("Error waiting for SolrCore to be loaded on
startup", e);
Review Comment:
yes, hence no need to throw an exception at a lower level; in task body
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
