dsmiley commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2646476270
Looking back at this a bit briefly. In general these plural form classes
should be very unreferenced except when the registry itself is needed (should
be rare). These classes should be con
uschindler commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2646355888
> Thanks for your feedback @uschindler 😄
>
> > Please be still careful to not use the plural s classes during
initialization on the original class. This would reintroduce the proble
malliaridis commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2646309035
Thanks for your feedback @uschindler 😄
> Please be still careful to not use the plural s classes during
initialization on the original class. This would reintroduce the problems.
uschindler commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2646291916
Please be still careful to not use the plural s classes during
initialization on the original class. This would reintroduce the problems. I
wasn't able to check all those patterns, but I
github-actions[bot] commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2625973468
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
malliaridis commented on code in PR #2881:
URL: https://github.com/apache/solr/pull/2881#discussion_r1860806598
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocRouter.java:
##
@@ -38,14 +36,24 @@
* @lucene.experimental
*/
public abstract class DocRouter {
- public s
malliaridis commented on code in PR #2881:
URL: https://github.com/apache/solr/pull/2881#discussion_r1860801651
##
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##
@@ -1128,9 +1131,9 @@ protected SolrCore(
initIndex(prev != null, reload);
initWriters();
malliaridis commented on code in PR #2881:
URL: https://github.com/apache/solr/pull/2881#discussion_r1860733744
##
solr/solrj/src/java/org/apache/solr/common/MapWriters.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
malliaridis commented on code in PR #2881:
URL: https://github.com/apache/solr/pull/2881#discussion_r186076
##
solr/core/src/java/org/apache/solr/search/FunctionQParser.java:
##
@@ -398,7 +398,7 @@ protected ValueSource parseValueSource(int flags) throws
SyntaxError {
malliaridis commented on code in PR #2881:
URL: https://github.com/apache/solr/pull/2881#discussion_r1860657766
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocRouter.java:
##
@@ -38,14 +36,24 @@
* @lucene.experimental
*/
public abstract class DocRouter {
- public s
malliaridis commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2498408658
Thanks for the review @dsmiley. I am not familiar enough with the modified
classes to know which is cnosidered internal, so your input is very valuable to
me. I generally try to follow t
dsmiley commented on code in PR #2881:
URL: https://github.com/apache/solr/pull/2881#discussion_r1855522803
##
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##
@@ -1128,9 +1131,9 @@ protected SolrCore(
initIndex(prev != null, reload);
initWriters();
-
malliaridis opened a new pull request, #2881:
URL: https://github.com/apache/solr/pull/2881
https://issues.apache.org/jira/browse/SOLR-16427
# Description
With the
[ClassInitializationDeadlock](https://errorprone.info/bugpattern/ClassInitializationDeadlock)
rule error-prone ch
13 matches
Mail list logo
