janhoy merged PR #2193:
URL: https://github.com/apache/solr/pull/2193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #2193:
URL: https://github.com/apache/solr/pull/2193#issuecomment-1903939234
The latest commits are looking great Thanks for the rename!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
epugh commented on PR #2193:
URL: https://github.com/apache/solr/pull/2193#issuecomment-1890057983
> > > > LGTM. I sort of wish it was the full `getProperty`.
> > >
> > >
> > > We can rename `getProp -> getProperty` if you feel it is better. The
code has still not left the bui
janhoy commented on PR #2193:
URL: https://github.com/apache/solr/pull/2193#issuecomment-1890049339
> > > LGTM. I sort of wish it was the full `getProperty`.
> >
> >
> > We can rename `getProp -> getProperty` if you feel it is better. The
code has still not left the building i
epugh commented on code in PR #2193:
URL: https://github.com/apache/solr/pull/2193#discussion_r1450967732
##
solr/modules/s3-repository/src/java/org/apache/solr/s3/S3BackupRepositoryConfig.java:
##
@@ -59,7 +58,7 @@ public S3StorageClient buildClient() {
}
private static
epugh commented on PR #2193:
URL: https://github.com/apache/solr/pull/2193#issuecomment-1890045409
> > LGTM. I sort of wish it was the full `getProperty`.
>
> We can rename `getProp -> getProperty` if you feel it is better. The code
has still not left the building in a release...
janhoy commented on PR #2193:
URL: https://github.com/apache/solr/pull/2193#issuecomment-1890044549
> LGTM. I sort of wish it was the full `getProperty`.
We can rename `getProp -> getProperty` if you feel it is better. The code
has still not left the building in a release...
--
janhoy commented on code in PR #2193:
URL: https://github.com/apache/solr/pull/2193#discussion_r1450967237
##
solr/modules/s3-repository/src/java/org/apache/solr/s3/S3BackupRepositoryConfig.java:
##
@@ -59,7 +58,7 @@ public S3StorageClient buildClient() {
}
private stati
