Re: [PR] SOLR-17774: Refactor initialization of GlobalOpenTelemetry [solr]

2025-05-29 Thread via GitHub
mlbiscoc commented on code in PR #3379: URL: https://github.com/apache/solr/pull/3379#discussion_r2114832472 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -423,6 +433,11 @@ public CoreContainer(NodeConfig config, CoresLocator locator, boolean asyncSolrC

[jira] [Updated] (SOLR-17774) Refactor initialization of Open Telemetry on startup

2025-05-29 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Biscocho updated SOLR-17774: Description: Solr initializes Open Telemetry by loading a tracer through `TracerConfigurato

[jira] [Updated] (SOLR-17774) Refactor initialization of Open Telemetry on startup

2025-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17774: -- Labels: pull-request-available (was: ) > Refactor initialization of Open Telemetry on startup

[PR] SOLR-17774: Refactor initialization of GlobalOpenTelemetry [solr]

2025-05-29 Thread via GitHub
mlbiscoc opened a new pull request, #3379: URL: https://github.com/apache/solr/pull/3379 This refactors how the Global Open Telemetry instance was set and adds `opentelemetry-exporter-prometheus` and `opentelemetry.sdk` into core as a dependency. `opentelemetry-exporter-prometheus` is neede

[jira] [Created] (SOLR-17774) Refactor initialization of Open Telemetry on startup

2025-05-29 Thread Matthew Biscocho (Jira)
Matthew Biscocho created SOLR-17774: --- Summary: Refactor initialization of Open Telemetry on startup Key: SOLR-17774 URL: https://issues.apache.org/jira/browse/SOLR-17774 Project: Solr Issue

Re: [PR] SOLR-17625 NamedList.findRecursive-> _get [solr]

2025-05-29 Thread via GitHub
dsmiley commented on code in PR #3355: URL: https://github.com/apache/solr/pull/3355#discussion_r2114388302 ## solr/core/src/test/org/apache/solr/search/facet/SpatialHeatmapFacetsTest.java: ## @@ -438,8 +436,7 @@ public void testJsonFacets() throws Exception {

Re: [PR] SOLR-17772: Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
epugh merged PR #3378: URL: https://github.com/apache/solr/pull/3378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Updated] (SOLR-17772) Tests for examples failing on Windows

2025-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17772: -- Labels: pull-request-available windows (was: windows) > Tests for examples failing on Windows

[jira] [Commented] (SOLR-17772) Tests for examples failing on Windows

2025-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955011#comment-17955011 ] ASF subversion and git services commented on SOLR-17772: Commit e

[jira] [Created] (SOLR-17773) Vector Search : Add support for Quantization

2025-05-29 Thread Atita Arora (Jira)
Atita Arora created SOLR-17773: -- Summary: Vector Search : Add support for Quantization Key: SOLR-17773 URL: https://issues.apache.org/jira/browse/SOLR-17773 Project: Solr Issue Type: New Feature

[jira] [Created] (SOLR-17772) Tests for examples failing on Windows

2025-05-29 Thread Rahul Goswami (Jira)
Rahul Goswami created SOLR-17772: Summary: Tests for examples failing on Windows Key: SOLR-17772 URL: https://issues.apache.org/jira/browse/SOLR-17772 Project: Solr Issue Type: Bug

Re: [PR] Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
epugh commented on PR #3378: URL: https://github.com/apache/solr/pull/3378#issuecomment-2919665135 Can you add a changes entry? And then when the tests pass I'll merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
rahulgoswami commented on code in PR #3378: URL: https://github.com/apache/solr/pull/3378#discussion_r2114128683 ## solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java: ## @@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd) throws IOExc

Re: [PR] Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
epugh commented on code in PR #3378: URL: https://github.com/apache/solr/pull/3378#discussion_r2114086764 ## solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java: ## @@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd) throws IOException

Re: [PR] Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
rahulgoswami commented on code in PR #3378: URL: https://github.com/apache/solr/pull/3378#discussion_r2114054937 ## solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java: ## @@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd) throws IOExc

Re: [PR] Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
rahulgoswami commented on code in PR #3378: URL: https://github.com/apache/solr/pull/3378#discussion_r2114054937 ## solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java: ## @@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd) throws IOExc

Re: [PR] Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
rahulgoswami commented on code in PR #3378: URL: https://github.com/apache/solr/pull/3378#discussion_r2114054937 ## solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java: ## @@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd) throws IOExc

Re: [PR] Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
rahulgoswami commented on code in PR #3378: URL: https://github.com/apache/solr/pull/3378#discussion_r2114054937 ## solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java: ## @@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd) throws IOExc

Re: [PR] Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
rahulgoswami commented on code in PR #3378: URL: https://github.com/apache/solr/pull/3378#discussion_r2114054937 ## solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java: ## @@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd) throws IOExc

[jira] [Commented] (SOLR-17458) Metrics: switch from DropWizard to OpenTelemetry

2025-05-29 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954955#comment-17954955 ] Matthew Biscocho commented on SOLR-17458: - I have a high level idea how to split

Re: [PR] SOLR-17625 NamedList.findRecursive-> _get [solr]

2025-05-29 Thread via GitHub
dsmiley commented on code in PR #3355: URL: https://github.com/apache/solr/pull/3355#discussion_r2113950364 ## solr/core/src/test/org/apache/solr/search/facet/SpatialHeatmapFacetsTest.java: ## @@ -441,11 +438,11 @@ public void testJsonFacets() throws Exception {

[jira] [Commented] (SOLR-17458) Metrics: switch from DropWizard to OpenTelemetry

2025-05-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954943#comment-17954943 ] David Smiley commented on SOLR-17458: - Ideally the SIP would give a sense of overall

Re: [PR] SOLR-17711 index fetcher doesn't need timeout [solr]

2025-05-29 Thread via GitHub
dsmiley commented on PR #3356: URL: https://github.com/apache/solr/pull/3356#issuecomment-2919383276 I quickly looked at Jetty HttpClient and there's no request timeout there. It's on the Jetty Request. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
epugh commented on code in PR #3378: URL: https://github.com/apache/solr/pull/3378#discussion_r2113850972 ## solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java: ## @@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd) throws IOException

Re: [PR] Tests for examples failing on Windows [solr]

2025-05-29 Thread via GitHub
epugh commented on code in PR #3378: URL: https://github.com/apache/solr/pull/3378#discussion_r2113847898 ## solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java: ## @@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd) throws IOException

[jira] [Commented] (SOLR-17679) Request for Documentation/Feature Improvement on Hybrid Lexical and Vector Search with Score Breakdown and Cutoff Logic

2025-05-29 Thread Renato Haeberli (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954908#comment-17954908 ] Renato Haeberli commented on SOLR-17679: [~khouli] Has any documentation been cre