Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]

2025-02-19 Thread via GitHub
mkhludnev commented on PR #3199: URL: https://github.com/apache/solr/pull/3199#issuecomment-2670634374 Ok. ~chatting to deepseek~ referring to JLS 15.12.2.5 calms me down a little. Should be fine, since the most specific method will be chosen. -- This is an automated message from the Apa

Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]

2025-02-19 Thread via GitHub
mkhludnev commented on PR #3199: URL: https://github.com/apache/solr/pull/3199#issuecomment-2670599951 Hm.. couldn't it cause 'unambiguous error'? I mean now we have two methods with (param) overloaded signature, almost all arguments passed into these methods implement both interfaces. Just

[I] Text to Vector Filter for Indexing [solr-operator]

2025-02-19 Thread via GitHub
yugankpant opened a new issue, #758: URL: https://github.com/apache/solr-operator/issues/758 Scope of this issue is to introduce support for automatic text vectorisation in Apache Solr, directly in the Analyzer chain during indexing. Since solr already have the capability of Text to V

Re: [PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-19 Thread via GitHub
dsmiley commented on PR #3163: URL: https://github.com/apache/solr/pull/3163#issuecomment-2670503495 FYI I'm *very* eager to examine this in detail but am on vacation this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] SOLR-17593: New home for default http2 client [solr]

2025-02-19 Thread via GitHub
dsmiley commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1962850987 ## solr/solrj/src/java/org/apache/solr/common/util/IOUtils.java: ## @@ -16,15 +16,14 @@ */ package org.apache.solr.common.util; -import java.io.Closeable; import jav

[PR] IOUtils: add back closeQuietly(Closeable) [solr]

2025-02-19 Thread via GitHub
dsmiley opened a new pull request, #3199: URL: https://github.com/apache/solr/pull/3199 To retain compatibility within 9x. Not bringing this to main/10x. This issue was introduced by [SOLR-17593: New home for default http2 client apache/solr#2689](https://github.com/apache/solr/pul

[jira] [Commented] (SOLR-14414) New Admin UI

2025-02-19 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928529#comment-17928529 ] Christos Malliaridis commented on SOLR-14414: - [~hossman] thanks for this use

[PR] Fix race condition in TestThinCache [solr]

2025-02-19 Thread via GitHub
HoustonPutman opened a new pull request, #3198: URL: https://github.com/apache/solr/pull/3198 Basically `onRemoval()` has a much weaker guarantee than it is assuming right now. This method can be called asynchronously, after the key is already gone locally. Or even after the new cache

[jira] [Created] (SOLR-17678) Return original score for reranked docs

2025-02-19 Thread Siju Varghese (Jira)
Siju Varghese created SOLR-17678: Summary: Return original score for reranked docs Key: SOLR-17678 URL: https://issues.apache.org/jira/browse/SOLR-17678 Project: Solr Issue Type: Improvement

Re: [PR] SOLR-17650: Fix tests for unordered buffered updates [solr]

2025-02-19 Thread via GitHub
dsmiley commented on code in PR #3197: URL: https://github.com/apache/solr/pull/3197#discussion_r1962529603 ## solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java: ## @@ -1027,6 +1028,64 @@ public static String assertJQ(SolrQueryRequest req, double delta, String...

[jira] [Updated] (SOLR-17650) Determine executor for UpdateLog reading

2025-02-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17650: -- Labels: pull-request-available (was: ) > Determine executor for UpdateLog reading > --

[PR] SOLR-17650: Fix tests for unordered buffered updates [solr]

2025-02-19 Thread via GitHub
HoustonPutman opened a new pull request, #3197: URL: https://github.com/apache/solr/pull/3197 https://issues.apache.org/jira/browse/SOLR-17650 According to the discussion in the JIRA, the behavior here is fine. We just need to update the tests now that buffered updates can be done in

[jira] [Updated] (SOLR-17572) Migrate Gradle files to use Kotlin DSL

2025-02-19 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17572: Labels: gradle newdev (was: gradle) > Migrate Gradle files to use Kotlin DSL > ---

[jira] [Commented] (SOLR-17667) Simplify and cleanup zombie server logic in LBSolrClient

2025-02-19 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928498#comment-17928498 ] Houston Putman commented on SOLR-17667: --- Yeah that sounds good to me. I checked and

[jira] [Created] (SOLR-17677) {!join} in delete-by-query throws ClassCastException and closes IndexWriter

2025-02-19 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17677: -- Summary: {!join} in delete-by-query throws ClassCastException and closes IndexWriter Key: SOLR-17677 URL: https://issues.apache.org/jira/browse/SOLR-17677 Project

[jira] [Created] (SOLR-17676) Enable wasmJs tests

2025-02-19 Thread Christos Malliaridis (Jira)
Christos Malliaridis created SOLR-17676: --- Summary: Enable wasmJs tests Key: SOLR-17676 URL: https://issues.apache.org/jira/browse/SOLR-17676 Project: Solr Issue Type: Improvement

Re: [PR] Bugfix: Disable wasmJs browser tests [solr]

2025-02-19 Thread via GitHub
malliaridis commented on code in PR #3195: URL: https://github.com/apache/solr/pull/3195#discussion_r1961745491 ## solr/ui/build.gradle.kts: ## @@ -55,14 +55,9 @@ kotlin { // Note that webpack.config.d/ contains additional configuration }

[jira] [Updated] (SOLR-17593) New CoreContainer.getDefaultHttpSolrClient (using Jetty HttpClient)

2025-02-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17593: -- Labels: pull-request-available (was: ) > New CoreContainer.getDefaultHttpSolrClient (using Jet

Re: [PR] SOLR-17593: New home for default http2 client [solr]

2025-02-19 Thread via GitHub
mkhludnev commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1961437392 ## solr/solrj/src/java/org/apache/solr/common/util/IOUtils.java: ## @@ -16,15 +16,14 @@ */ package org.apache.solr.common.util; -import java.io.Closeable; import j

Re: [PR] SOLR-17635: unmarshalling Map to SimpleOrderedMap if key i of type St… [solr]

2025-02-19 Thread via GitHub
renatoh commented on code in PR #3163: URL: https://github.com/apache/solr/pull/3163#discussion_r1961300602 ## solr/solrj/src/java/org/apache/solr/common/util/Utils.java: ## @@ -290,7 +290,7 @@ public static Object fromJSON(byte[] utf8) { } public static Object fromJSON(