mkhludnev commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1961437392
########## solr/solrj/src/java/org/apache/solr/common/util/IOUtils.java: ########## @@ -16,15 +16,14 @@ */ package org.apache.solr.common.util; -import java.io.Closeable; import java.lang.invoke.MethodHandles; import org.slf4j.Logger; import org.slf4j.LoggerFactory; public class IOUtils { private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); - public static void closeQuietly(Closeable closeable) { + public static void closeQuietly(AutoCloseable closeable) { Review Comment: fwiw it was not fully backward compatible https://github.com/SearchScale/dataimporthandler/issues/91 sigh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org