HoustonPutman opened a new pull request, #3198: URL: https://github.com/apache/solr/pull/3198
Basically `onRemoval()` has a much weaker guarantee than it is assuming right now. This method can be called asynchronously, after the key is already gone locally. Or even after the new cache is created, and it doesn't have the value that is being removed in it's local cache. This is a way to solve most of the issues, but one race condition still remains. (Not sure it's possible to solve) If the cache evicts a key, then the user puts that key with its original value right afterwards, this code will still assume it should be removed. Since we don't have access to timings for removal and addition, there is no way to fix this. (I think). But for the sake of our small test failures, this should be sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
