Re: [PR] SOLR-11191: SolrIndexSplitter: Routing child docs by _root_ when available [solr]

2024-10-28 Thread via GitHub
zkendall commented on code in PR #2799: URL: https://github.com/apache/solr/pull/2799#discussion_r1820038021 ## solr/core/src/test/org/apache/solr/cloud/SplitShardTest.java: ## @@ -174,6 +164,50 @@ public void testSplitFuzz() throws Exception { assertEquals("wrong range in

Re: [PR] SOLR-11191: SolrIndexSplitter: Routing child docs by _root_ when available [solr]

2024-10-28 Thread via GitHub
zkendall commented on code in PR #2799: URL: https://github.com/apache/solr/pull/2799#discussion_r1820110853 ## solr/core/src/test/org/apache/solr/cloud/SplitShardTest.java: ## @@ -174,6 +164,50 @@ public void testSplitFuzz() throws Exception { assertEquals("wrong range in

Re: [PR] SOLR-17516: LBHttpSolrClient: support HttpJdkSolrClient [solr]

2024-10-28 Thread via GitHub
dsmiley commented on code in PR #2805: URL: https://github.com/apache/solr/pull/2805#discussion_r1820061320 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/LBHttp2SolrClientIntegrationTest.java: ## @@ -119,22 +114,45 @@ public void tearDown() throws Exception {

Re: [PR] SOLR-11191: SolrIndexSplitter: Routing child docs by _root_ when available [solr]

2024-10-28 Thread via GitHub
zkendall commented on code in PR #2799: URL: https://github.com/apache/solr/pull/2799#discussion_r1820041702 ## solr/solr-ref-guide/modules/indexing-guide/pages/indexing-nested-documents.adoc: ## @@ -304,6 +305,11 @@ Instead, use delete-by-query (most efficient) or xref:partial

[jira] [Resolved] (SOLR-12951) Should Child Doc Ids be unique?

2024-10-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-12951. - Resolution: Abandoned > Should Child Doc Ids be unique? > --- > >

Re: [PR] SOLR-11191: SolrIndexSplitter: Routing child docs by _root_ when available [solr]

2024-10-28 Thread via GitHub
dsmiley commented on code in PR #2799: URL: https://github.com/apache/solr/pull/2799#discussion_r1820076104 ## solr/core/src/test/org/apache/solr/cloud/SplitShardTest.java: ## @@ -174,6 +164,50 @@ public void testSplitFuzz() throws Exception { assertEquals("wrong range in s

Re: [PR] SOLR-11191: SolrIndexSplitter: Routing child docs by _root_ when available [solr]

2024-10-28 Thread via GitHub
zkendall commented on code in PR #2799: URL: https://github.com/apache/solr/pull/2799#discussion_r1820038021 ## solr/core/src/test/org/apache/solr/cloud/SplitShardTest.java: ## @@ -174,6 +164,50 @@ public void testSplitFuzz() throws Exception { assertEquals("wrong range in

Re: [PR] SOLR-11191: SolrIndexSplitter: Routing child docs by _root_ when available [solr]

2024-10-28 Thread via GitHub
zkendall commented on code in PR #2799: URL: https://github.com/apache/solr/pull/2799#discussion_r1820041702 ## solr/solr-ref-guide/modules/indexing-guide/pages/indexing-nested-documents.adoc: ## @@ -304,6 +305,11 @@ Instead, use delete-by-query (most efficient) or xref:partial

Re: [PR] SOLR-11191: SolrIndexSplitter: Routing child docs by _root_ when available [solr]

2024-10-28 Thread via GitHub
zkendall commented on code in PR #2799: URL: https://github.com/apache/solr/pull/2799#discussion_r1820038021 ## solr/core/src/test/org/apache/solr/cloud/SplitShardTest.java: ## @@ -174,6 +164,50 @@ public void testSplitFuzz() throws Exception { assertEquals("wrong range in

[jira] [Updated] (SOLR-17471) upgrade to Lucene 9.12.0

2024-10-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17471: Fix Version/s: (was: main (10.0)) Priority: Blocker (was: Major) > upgrade to Lucene

Re: [PR] SOLR-11191: SolrIndexSplitter: Routing child docs by _root_ when available [solr]

2024-10-28 Thread via GitHub
dsmiley commented on code in PR #2799: URL: https://github.com/apache/solr/pull/2799#discussion_r1819941095 ## solr/core/src/test/org/apache/solr/cloud/SplitShardTest.java: ## @@ -174,6 +164,50 @@ public void testSplitFuzz() throws Exception { assertEquals("wrong range in s

Re: [PR] Update dependency com.fasterxml.jackson:jackson-bom to v2.18.1 [solr]

2024-10-28 Thread via GitHub
solrbot commented on PR #2806: URL: https://github.com/apache/solr/pull/2806#issuecomment-2442948143 ### ⚠️ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, in

[PR] Update dependency com.fasterxml.jackson:jackson-bom to v2.18.1 [solr]

2024-10-28 Thread via GitHub
solrbot opened a new pull request, #2806: URL: https://github.com/apache/solr/pull/2806 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.fasterxml.jackson:jackson-bom](https://redirect.github.com/FasterXML/jackson-bom) | depe

[jira] [Updated] (SOLR-17516) LBHttpSolrClient: support HttpJdkSolrClient

2024-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17516: -- Labels: pull-request-available (was: ) > LBHttpSolrClient: support HttpJdkSolrClient > ---

[PR] SOLR-17516: LBHttpSolrClient: support HttpJdkSolrClient [solr]

2024-10-28 Thread via GitHub
jdyer1 opened a new pull request, #2805: URL: https://github.com/apache/solr/pull/2805 This is a minimal PR to add Load Balancing functionality for the HttpJdkSolrClient. Included is test refactoring, adding the *JdkClient as a random choice for the integration test. The result is n

[jira] [Commented] (SOLR-17321) Bump minimum required Java version to 21

2024-10-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893635#comment-17893635 ] ASF subversion and git services commented on SOLR-17321: Commit 9

Re: [PR] SOLR-17321: Cleanup JDK version related logic in scripts [solr]

2024-10-28 Thread via GitHub
malliaridis merged PR #2792: URL: https://github.com/apache/solr/pull/2792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[PR] SOLR-17321: Update ecj compiler versions to JDK 17 [solr]

2024-10-28 Thread via GitHub
malliaridis opened a new pull request, #2804: URL: https://github.com/apache/solr/pull/2804 https://issues.apache.org/jira/browse/SOLR-17321 # Description With the JDK upgrade we can bump the JDT compiler versions as well. I am linking these PRs to the Jira issue because

Re: [PR] SOLR-11191: SolrIndexSplitter: Routing child docs by _root_ when available [solr]

2024-10-28 Thread via GitHub
zkendall commented on code in PR #2799: URL: https://github.com/apache/solr/pull/2799#discussion_r1819820312 ## solr/core/src/test/org/apache/solr/cloud/SplitShardTest.java: ## @@ -174,6 +164,50 @@ public void testSplitFuzz() throws Exception { assertEquals("wrong range in

Re: [PR] SOLR-17515: Always init Http2SolrClient authStore [solr]

2024-10-28 Thread via GitHub
dsmiley commented on PR #2802: URL: https://github.com/apache/solr/pull/2802#issuecomment-2442649456 I'm looking into the Crave thing. Quality workmanship Jason -- thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Cleanup JDK version related logic in scripts [solr]

2024-10-28 Thread via GitHub
malliaridis commented on code in PR #2792: URL: https://github.com/apache/solr/pull/2792#discussion_r1819644230 ## solr/bin/solr: ## @@ -1054,31 +1054,13 @@ fi # Establish default GC logging opts if no env var set (otherwise init to sensible default) if [ -z "${GC_LOG_OPTS}

Re: [PR] SOLR-17321: Cleanup JDK version related logic in scripts [solr]

2024-10-28 Thread via GitHub
epugh commented on PR #2792: URL: https://github.com/apache/solr/pull/2792#issuecomment-2442546485 I suspect that the failing test isn't because of these changes! Just run ` ./gradlew :solr:core:test --tests "org.apache.solr.cloud.api.collections.LocalFSCloudIncrementalBackupTest.testSkipC

[jira] [Commented] (SOLR-17497) Pull replicas throws AlreadyClosedException

2024-10-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893601#comment-17893601 ] David Smiley commented on SOLR-17497: - FYI since SOLR-17448 isn't released yet, any f

[jira] [Commented] (SOLR-17448) Audit usage of ExecutorService#submit in Solr codebase

2024-10-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893599#comment-17893599 ] David Smiley commented on SOLR-17448: - BTW there have been some com.carrotsearch.ran

Re: [PR] SOLR-10654: Prometheus regex cloud pattern fix for core names [solr]

2024-10-28 Thread via GitHub
dsmiley commented on PR #2795: URL: https://github.com/apache/solr/pull/2795#issuecomment-2442483636 Thanks; an easy fix. You linked this to SOLR-10654 but that issue was already released. A new issue must be created. We can get this into 9.7.1 (FYI @anshumg as RM) -- This is an auto

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-10-28 Thread via GitHub
dsmiley commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1819655529 ## solr/solrj-zookeeper/build.gradle: ## @@ -37,6 +37,13 @@ dependencies { implementation 'org.apache.httpcomponents:httpclient' implementation 'org.apache.httpcom

Re: [PR] Cleanup JDK version related logic in scripts [solr]

2024-10-28 Thread via GitHub
malliaridis commented on PR #2792: URL: https://github.com/apache/solr/pull/2792#issuecomment-2442458483 > I noticed you changed back to Draft? I switched it into draft to investigate the test that failed. I am not sure if it is related. -- This is an automated message from the Apa

Re: [PR] Fix StatusTool related issues on Windows [solr]

2024-10-28 Thread via GitHub
malliaridis merged PR #2798: URL: https://github.com/apache/solr/pull/2798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Resolved] (SOLR-17413) UpdateLog Replay can throw ConcurrentModificationException from sharing the request

2024-10-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-17413. Fix Version/s: 9.8 Assignee: Jason Gerlowski Resolution: Fixed > UpdateLog

Re: [PR] SOLR-17413: ulog replay should copy SolrQueryRequest [solr]

2024-10-28 Thread via GitHub
gerlowskija commented on code in PR #2765: URL: https://github.com/apache/solr/pull/2765#discussion_r1819471160 ## solr/core/src/java/org/apache/solr/update/UpdateLog.java: ## @@ -2097,10 +2098,19 @@ public void doReplay(TransactionLog translog) { UpdateRequestProcessor

Re: [PR] Fix release wizard to remove from Solr space before attempting Lucene [solr]

2024-10-28 Thread via GitHub
anshumg merged PR #2796: URL: https://github.com/apache/solr/pull/2796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[PR] Fix release wizard to remove from Solr space before attempting Lucene space [solr]

2024-10-28 Thread via GitHub
anshumg opened a new pull request, #2803: URL: https://github.com/apache/solr/pull/2803 * Fix release wizard to stop attempting to remove old artifacts from the Lucene space -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (SOLR-17413) UpdateLog Replay can throw ConcurrentModificationException from sharing the request

2024-10-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893571#comment-17893571 ] ASF subversion and git services commented on SOLR-17413: Commit a

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-10-28 Thread via GitHub
HoustonPutman commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1819484898 ## solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/BadClusterTest.java: ## @@ -97,15 +102,15 @@ private void testAllNodesDown() throws Exception {

[jira] [Commented] (SOLR-17413) UpdateLog Replay can throw ConcurrentModificationException from sharing the request

2024-10-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893567#comment-17893567 ] ASF subversion and git services commented on SOLR-17413: Commit 0

Re: [PR] SOLR-17413: ulog replay should copy SolrQueryRequest [solr]

2024-10-28 Thread via GitHub
gerlowskija merged PR #2765: URL: https://github.com/apache/solr/pull/2765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[I] Solr with 2 ports https - each port with different keystore [solr-operator]

2024-10-28 Thread via GitHub
marcokonsultex opened a new issue, #727: URL: https://github.com/apache/solr-operator/issues/727 Hello, I am using Solr together with Alfresco Content ECM for indexing. I have Solr installed manually on my server and generated a certificate by Alfresco to connect in trust throu

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-10-28 Thread via GitHub
HoustonPutman commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1819481659 ## solr/solrj-zookeeper/build.gradle: ## @@ -37,6 +37,13 @@ dependencies { implementation 'org.apache.httpcomponents:httpclient' implementation 'org.apache.h

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-10-28 Thread via GitHub
HoustonPutman commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1819446921 ## solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/BadClusterTest.java: ## @@ -97,15 +102,15 @@ private void testAllNodesDown() throws Exception {

Re: [PR] SOLR-10654: Prometheus regex cloud pattern fix for core names [solr]

2024-10-28 Thread via GitHub
mlbiscoc commented on PR #2795: URL: https://github.com/apache/solr/pull/2795#issuecomment-2442023093 @dsmiley mind taking a look at this? Oversight on my part for the core regex pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] SOLR-17515: Always init Http2SolrClient authStore [solr]

2024-10-28 Thread via GitHub
gerlowskija opened a new pull request, #2802: URL: https://github.com/apache/solr/pull/2802 https://issues.apache.org/jira/browse/SOLR-17515 # Description Prior to this commit, Http2SolrClient only initialized its 'authenticationStore' instance var when creating a fresh Jet

[jira] [Updated] (SOLR-17515) Recovery fails in Solr 9.7.0 if basic-auth is enabled

2024-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17515: -- Labels: pull-request-available (was: ) > Recovery fails in Solr 9.7.0 if basic-auth is enabled

[jira] [Commented] (SOLR-17515) Recovery fails in Solr 9.7.0 if basic-auth is enabled

2024-10-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893500#comment-17893500 ] Jason Gerlowski commented on SOLR-17515: Alright, a few updates: *First, a worka

[jira] [Resolved] (SOLR-17511) CLI: Resolve -i conflicts (async-id, cluster-id)

2024-10-28 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17511. -- Fix Version/s: 9.8 Resolution: Fixed > CLI: Resolve -i conflicts (async-id, cluster-id) > --

[jira] [Commented] (SOLR-17511) CLI: Resolve -i conflicts (async-id, cluster-id)

2024-10-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893470#comment-17893470 ] ASF subversion and git services commented on SOLR-17511: Commit f

[jira] [Commented] (SOLR-17511) CLI: Resolve -i conflicts (async-id, cluster-id)

2024-10-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893469#comment-17893469 ] ASF subversion and git services commented on SOLR-17511: Commit 6

[jira] [Updated] (SOLR-17523) EmbeddedSolrServer support for SolrCloud (collection-to-core lookup)

2024-10-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17523: Priority: Minor (was: Major) > EmbeddedSolrServer support for SolrCloud (collection-to-core lookup

[jira] [Created] (SOLR-17523) EmbeddedSolrServer support for SolrCloud (collection-to-core lookup)

2024-10-28 Thread David Smiley (Jira)
David Smiley created SOLR-17523: --- Summary: EmbeddedSolrServer support for SolrCloud (collection-to-core lookup) Key: SOLR-17523 URL: https://issues.apache.org/jira/browse/SOLR-17523 Project: Solr

[jira] [Closed] (SOLR-9545) DataImportHandler throws NPE to logs when pk attribute is not present when delta query is used

2024-10-28 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh closed SOLR-9545. --- > DataImportHandler throws NPE to logs when pk attribute is not present when > delta query is used >

[jira] [Commented] (SOLR-13688) Make the bin/solr export command to run one thread per shard

2024-10-28 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893452#comment-17893452 ] Eric Pugh commented on SOLR-13688: -- FYI, in SOLR-14673 I've added a bin/solr stream tool

[jira] [Updated] (SOLR-11191) Shard Split doesn't work on indexes that have child documents

2024-10-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-11191: Summary: Shard Split doesn't work on indexes that have child documents (was: Shard Split doesn't w

[jira] [Commented] (SOLR-17511) CLI: Resolve -i conflicts (async-id, cluster-id)

2024-10-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893448#comment-17893448 ] ASF subversion and git services commented on SOLR-17511: Commit 7

Re: [PR] SOLR-17511: Deprecate -i CLI usages [solr]

2024-10-28 Thread via GitHub
epugh merged PR #2794: URL: https://github.com/apache/solr/pull/2794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-10-28 Thread via GitHub
timatbw commented on PR #2742: URL: https://github.com/apache/solr/pull/2742#issuecomment-2441360783 I've just realised the registration part of this work is not necessary! All that's really needed is the public modifier changes. I'm going to simplify the PR down to just that bit. Th

[jira] [Created] (SOLR-17521) Remove cross-dc from Sandbox

2024-10-28 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17521: Summary: Remove cross-dc from Sandbox Key: SOLR-17521 URL: https://issues.apache.org/jira/browse/SOLR-17521 Project: Solr Issue Type: Task Security Level: Publ

Re: [PR] Cleanup JDK version related logic in scripts [solr]

2024-10-28 Thread via GitHub
epugh commented on code in PR #2792: URL: https://github.com/apache/solr/pull/2792#discussion_r1818879760 ## solr/bin/solr: ## @@ -1054,31 +1054,13 @@ fi # Establish default GC logging opts if no env var set (otherwise init to sensible default) if [ -z "${GC_LOG_OPTS}" ]; t

Re: [PR] SOLR-11191: SolrIndexSplitter: Routing child docs by _root_ when available [solr]

2024-10-28 Thread via GitHub
epugh commented on PR #2799: URL: https://github.com/apache/solr/pull/2799#issuecomment-2441290685 I am glad to see we are giving this feature some love. Thanks @dsmiley for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log o