Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-10-24 Thread via GitHub
dsmiley commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1815068705 ## gradle/testing/randomization/policies/solr-tests.policy: ## @@ -50,6 +50,7 @@ grant { permission java.net.SocketPermission "127.0.0.1:4", "connect,resolve"; permiss

[jira] [Comment Edited] (SOLR-17161) Separate out a solrj-jetty artifact (10.0)

2024-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892565#comment-17892565 ] Jason Gerlowski edited comment on SOLR-17161 at 10/24/24 5:04 PM: -

[PR] Update org.apache.zookeeper:* to v3.9.3 [solr]

2024-10-24 Thread via GitHub
solrbot opened a new pull request, #2793: URL: https://github.com/apache/solr/pull/2793 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.zookeeper:zookeeper-jute](http://zookeeper.apache.org) ([source](https://gitbox.ap

Re: [PR] Add docs detailing our ASF Jenkins usage [solr]

2024-10-24 Thread via GitHub
gerlowskija merged PR #2767: URL: https://github.com/apache/solr/pull/2767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] Add docs detailing our ASF Jenkins usage [solr]

2024-10-24 Thread via GitHub
gerlowskija commented on PR #2767: URL: https://github.com/apache/solr/pull/2767#issuecomment-2436146523 > I'm almost surprised this went here instead of Confluence as it's easier to edit/collaborate on a wiki instead of in code and do PR process. I think that was probably true once,

Re: [PR] Add docs detailing our ASF Jenkins usage [solr]

2024-10-24 Thread via GitHub
gerlowskija commented on PR #2767: URL: https://github.com/apache/solr/pull/2767#issuecomment-2436148109 Thanks all for the review - merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] [branch_9x] Backport Switched from HTTP1 to HTTP2 in SolrClientCloudManager [solr]

2024-10-24 Thread via GitHub
iamsanjay opened a new pull request, #2791: URL: https://github.com/apache/solr/pull/2791 [SOLR-16503](https://issues.apache.org/jira/browse/SOLR-16503) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Cleanup JDK version related logic in scripts [solr]

2024-10-24 Thread via GitHub
malliaridis opened a new pull request, #2792: URL: https://github.com/apache/solr/pull/2792 # Description With the min JDK 21 requirement some code snippets in `bin/solr.cmd` and `bin/solr` can be cleaned up. # Solution Cleanup obsolete code in `bin/solr.cmd` and `bin/so

[jira] [Commented] (SOLR-16450) Proper handling on watcher registration failure in `ZkStateReader#waitForState

2024-10-24 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892591#comment-17892591 ] Gus Heck commented on SOLR-16450: - This is labeled a blocker, and there's no fix version,

Re: [PR] Cleanup JDK version related logic in scripts [solr]

2024-10-24 Thread via GitHub
malliaridis commented on code in PR #2792: URL: https://github.com/apache/solr/pull/2792#discussion_r1815543421 ## solr/bin/solr: ## @@ -1054,31 +1054,13 @@ fi # Establish default GC logging opts if no env var set (otherwise init to sensible default) if [ -z "${GC_LOG_OPTS}

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-10-24 Thread via GitHub
timatbw commented on code in PR #2742: URL: https://github.com/apache/solr/pull/2742#discussion_r1815500548 ## solr/core/src/java/org/apache/solr/search/facet/FacetParser.java: ## @@ -138,21 +139,30 @@ public Object parseFacetOrStat(String key, Object o) throws SyntaxError {

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-10-24 Thread via GitHub
timatbw commented on code in PR #2742: URL: https://github.com/apache/solr/pull/2742#discussion_r1815497148 ## solr/core/src/java/org/apache/solr/search/facet/FacetParser.java: ## @@ -138,21 +139,30 @@ public Object parseFacetOrStat(String key, Object o) throws SyntaxError {

[jira] [Comment Edited] (SOLR-17161) Separate out a solrj-jetty artifact (10.0)

2024-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892565#comment-17892565 ] Jason Gerlowski edited comment on SOLR-17161 at 10/24/24 5:05 PM: -

Re: [PR] Replace CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager [solr]

2024-10-24 Thread via GitHub
iamsanjay merged PR #2751: URL: https://github.com/apache/solr/pull/2751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-10-24 Thread via GitHub
mkhludnev commented on PR #2742: URL: https://github.com/apache/solr/pull/2742#issuecomment-2435694762 oh gosh.. I figure it out how to update PR as a maintainer. The problem was I did it by https auth from Idea, but it seems it requested token only for my account and can't push into someon

Re: [PR] [branch_9x] Backport Switched from HTTP1 to HTTP2 in SolrClientCloudManager [solr]

2024-10-24 Thread via GitHub
iamsanjay merged PR #2791: URL: https://github.com/apache/solr/pull/2791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-10-24 Thread via GitHub
dsmiley commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1815061933 ## solr/solrj-zookeeper/build.gradle: ## @@ -32,6 +32,13 @@ dependencies { implementation project(':solr:solrj') +api('org.apache.curator:curator-client', { Re

Re: [PR] SOLR-17494: Remove language specific writer types [solr]

2024-10-24 Thread via GitHub
gerlowskija commented on PR #2758: URL: https://github.com/apache/solr/pull/2758#issuecomment-2435146190 Woohoo, thanks @epugh ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme