malliaridis opened a new pull request, #2792: URL: https://github.com/apache/solr/pull/2792
# Description With the min JDK 21 requirement some code snippets in `bin/solr.cmd` and `bin/solr` can be cleaned up. # Solution Cleanup obsolete code in `bin/solr.cmd` and `bin/solr`. **To the reviewers**: Please review carefully the GC-related changes, as I am not sure what is supported and what not in the newer versions. I tried to remove only obsolete cases, but I am not sure how to test the configurations. # Tests No tests modified. Some of the tests currently fail when running `./gradlew check` (currently inspecting). # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
