[jira] [Commented] (SOLR-4587) Implement Saved Searches a la ElasticSearch Percolator

2024-04-08 Thread Luke Kot-Zaniewski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835006#comment-17835006 ] Luke Kot-Zaniewski commented on SOLR-4587: -- Greetings, I've raised this PR [https

[jira] [Comment Edited] (SOLR-4587) Implement Saved Searches a la ElasticSearch Percolator

2024-04-08 Thread Luke Kot-Zaniewski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835006#comment-17835006 ] Luke Kot-Zaniewski edited comment on SOLR-4587 at 4/8/24 5:59 PM: --

[jira] [Comment Edited] (SOLR-4587) Implement Saved Searches a la ElasticSearch Percolator

2024-04-08 Thread Luke Kot-Zaniewski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835006#comment-17835006 ] Luke Kot-Zaniewski edited comment on SOLR-4587 at 4/8/24 5:59 PM: --

[jira] [Comment Edited] (SOLR-4587) Implement Saved Searches a la ElasticSearch Percolator

2024-04-08 Thread Luke Kot-Zaniewski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835006#comment-17835006 ] Luke Kot-Zaniewski edited comment on SOLR-4587 at 4/8/24 5:59 PM: --

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
epugh commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2043326665 @wwelling based on the conversation above, I am going to close this PR. If you decide to move forward with the nesting of both `/solr` and `/api` as a new feature, please open a JIRA, and I'd

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
epugh closed pull request #2388: Use hostContext property for RewriteHandler rules URL: https://github.com/apache/solr/pull/2388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-04-08 Thread via GitHub
epugh commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-2043320481 https://github.com/apache/commons-cli/pull/252 replaced what I proposed and was merged. Now waiting on a release! -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-04-08 Thread via GitHub
dsmiley commented on PR #2248: URL: https://github.com/apache/solr/pull/2248#issuecomment-2043307525 Yes I mean *the* FixedBitSet (otherwise I just would have said a bit set). No I don't know of similar code doing this, and I don't expect it's in Lucene/Solr already. Lucene is very segmen

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
dsmiley commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2042929556 My concern is avoiding complexity 99+% of users don't need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
dsmiley commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2042927447 I think aliasing /solr would be simpler than inserting a root. And while I wasn't supportive of aliasing... if it can be done simply in jetty.xml and toggled off then why not. -- This is

Re: [PR] SOLR-16833: Add blog to Solr website [solr-site]

2024-04-08 Thread via GitHub
dsmiley commented on PR #97: URL: https://github.com/apache/solr-site/pull/97#issuecomment-2042913949 > the first post could announce the blog, discuss the rationale, and describe how to contribute/submit posts +1 perfect -- This is an automated message from the Apache Git Service.

Re: [PR] Demonstrate a test framework bug [solr]

2024-04-08 Thread via GitHub
jdyer1 commented on PR #2242: URL: https://github.com/apache/solr/pull/2242#issuecomment-2042874530 Thank you for looking at this @janhoy. My belief here is that if server-specific code in `ExecutorUtil` was moved out of SolrJ, this would completely solve the problem. In particular I woul

Re: [PR] SOLR-16833: Add blog to Solr website [solr-site]

2024-04-08 Thread via GitHub
gerlowskija commented on PR #97: URL: https://github.com/apache/solr-site/pull/97#issuecomment-2042873115 I wanted to let this sit a nice long time, as it's a big change to our website. But it's been at least a month, and the bit of feedback this did get was positive! So I'll look to comm

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
epugh commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2042870864 I chatted a bit with @gerlowskija about this ticket, and I think he was supportive of the idea of being able to insert a root hostcontext that would go between `http://myserver:8983` and the `

[jira] [Comment Edited] (SOLR-17018) LTR queries producing out of memory issues

2024-04-08 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834936#comment-17834936 ] Alessandro Benedetti edited comment on SOLR-17018 at 4/8/24 2:07 PM: --

[jira] [Resolved] (SOLR-17018) LTR queries producing out of memory issues

2024-04-08 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti resolved SOLR-17018. - Resolution: Fixed Thanks to everyone involved, the contribution is now merged and

[jira] [Comment Edited] (SOLR-17018) LTR queries producing out of memory issues

2024-04-08 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834936#comment-17834936 ] Alessandro Benedetti edited comment on SOLR-17018 at 4/8/24 2:07 PM: --

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-08 Thread via GitHub
wwelling commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2042852384 @dsmiley thanks. We will give that a try. Would be easy enough to mount a file for additional routing. Will have to see if it supports system variable or environment variable substitution.

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-04-08 Thread via GitHub
cpoerschke commented on PR #2248: URL: https://github.com/apache/solr/pull/2248#issuecomment-2042815244 > ... Couldn't we build segment level FixedBitSets (no safety issue) and then at the end combine into a master FixedBitSet so that we have our DocSet? It could even be made to be long-ali

Re: [PR] SOLR-17153 Resolve IndexOutOfBoundsException [solr]

2024-04-08 Thread via GitHub
dsmiley commented on PR #2393: URL: https://github.com/apache/solr/pull/2393#issuecomment-2042659874 That the method signature changes doesn't affect our ability to test; maybe you were thinking a unit test. I much prefer an integration test (using SolrCloudTestCase). All we need to do is

Re: [PR] SOLR-17153 Resolve IndexOutOfBoundsException [solr]

2024-04-08 Thread via GitHub
aparnasuresh85 commented on PR #2393: URL: https://github.com/apache/solr/pull/2393#issuecomment-2042466145 > If Eric found a bug then it seems we need a test for this bug I had the same thought. But I now see the line of code that caused it is no longer being used. The call _resolveD