aparnasuresh85 commented on PR #2393:
URL: https://github.com/apache/solr/pull/2393#issuecomment-2042466145

   > If Eric found a bug then it seems we need a test for this bug
   
   I had the same thought. But I now see the line of code that caused it is no 
longer being used. The call _resolveDocCollection()_ is now being invoked 
within _getCoreByCollection()_ and its signature has also changed.
   
   What would be the test case of the new test? We would need one that doesnt 
create a collection or noneof the usual ones. Eric tried to start solr and 
launch the admin page.....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to