dsmiley commented on PR #2393: URL: https://github.com/apache/solr/pull/2393#issuecomment-2042659874
That the method signature changes doesn't affect our ability to test; maybe you were thinking a unit test. I much prefer an integration test (using SolrCloudTestCase). All we need to do is figure out what URL into Solr, in what situation (a collection existing or not? time-routed-alias? To a node with a core for the collection or not?) and do the same in a test. It should fail prior to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
