Re: [PR] SOLR-16796: introduce org.cyclonedx.bom gradle plugin [solr]

2024-04-01 Thread via GitHub
github-actions[bot] commented on PR #1203: URL: https://github.com/apache/solr/pull/1203#issuecomment-2030817225 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] Add correct exception logging in the ExecutorUtil [solr]

2024-04-01 Thread via GitHub
HoustonPutman commented on code in PR #2384: URL: https://github.com/apache/solr/pull/2384#discussion_r1546952877 ## solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java: ## @@ -314,15 +314,19 @@ public void execute(final Runnable command) { if (t ins

Re: [PR] Add correct exception logging in the ExecutorUtil [solr]

2024-04-01 Thread via GitHub
madrob commented on code in PR #2384: URL: https://github.com/apache/solr/pull/2384#discussion_r1546934660 ## solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java: ## @@ -314,15 +314,19 @@ public void execute(final Runnable command) { if (t instanceof

Re: [PR] Add correct exception logging in the ExecutorUtil [solr]

2024-04-01 Thread via GitHub
madrob commented on PR #2384: URL: https://github.com/apache/solr/pull/2384#issuecomment-2030706703 This took me a bit of experimenting with locally, but I understand what's going on now and agree that the new ordering is correct. Thanks for cleaning this up @HoustonPutman! -- This is an

Re: [PR] SOLR-17211: HttpJdkSolrClient Support Async requests [solr]

2024-04-01 Thread via GitHub
dsmiley commented on code in PR #2374: URL: https://github.com/apache/solr/pull/2374#discussion_r1546911504 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java: ## @@ -469,6 +531,23 @@ protected String allProcessorSupportedContentTypesCommaDelimited(

[PR] Ref Guide: Remove note about Zookeeper client TLS support [solr]

2024-04-01 Thread via GitHub
molnarp opened a new pull request, #2385: URL: https://github.com/apache/solr/pull/2385 Zookeeper client TLS works fine with Java, and all referred issues are either closed or refer to the above fact. # Checklist Please review the following and check all that apply: - [

Re: [PR] Add correct exception logging in the ExecutorUtil [solr]

2024-04-01 Thread via GitHub
HoustonPutman commented on PR #2384: URL: https://github.com/apache/solr/pull/2384#issuecomment-2030560252 An example of how this would fix exception logging: Existing implementation: ``` 2024-04-01 21:01:38.810 ERROR (coreZkRegister-1-thread-1-processing-172.17.0.2:8983_sol

[PR] Add correct exception logging in the ExecutorUtil [solr]

2024-04-01 Thread via GitHub
HoustonPutman opened a new pull request, #2384: URL: https://github.com/apache/solr/pull/2384 This actually logs the correct stack trace for an exception caught in the ExecutorUtil. It also provides the correct ordering of "causes" unlike the way it was previously implemented, where

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-04-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832928#comment-17832928 ] David Smiley commented on SOLR-13350: - Do we have a limited queue for the pool, leadi

Re: [PR] SOLR-17211: HttpJdkSolrClient Support Async requests [solr]

2024-04-01 Thread via GitHub
jdyer1 commented on code in PR #2374: URL: https://github.com/apache/solr/pull/2374#discussion_r1546681105 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java: ## @@ -469,6 +531,23 @@ protected String allProcessorSupportedContentTypesCommaDelimited(

[PR] SOLR-17134: Bucketed rate limiting [solr]

2024-04-01 Thread via GitHub
noblepaul opened a new pull request, #2383: URL: https://github.com/apache/solr/pull/2383 This PR implements support for bucketed rate limiting based on a header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-04-01 Thread via GitHub
kotman12 opened a new pull request, #2382: URL: https://github.com/apache/solr/pull/2382 # Description The module hopes to simplify distribution and scaling query-indexes for monitoring and alerting workflows (also known as reverse search) by providing a bridge between solr-managed s

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-04-01 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832913#comment-17832913 ] Ishan Chattopadhyaya commented on SOLR-13350: - {code} java.util.concurrent.Re

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-04-01 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832907#comment-17832907 ] Ishan Chattopadhyaya commented on SOLR-13350: - I think I understand what is g

Re: [I] Support replicaPlacementFactory in solr.xml [solr-operator]

2024-04-01 Thread via GitHub
dsmiley commented on issue #691: URL: https://github.com/apache/solr-operator/issues/691#issuecomment-2030176967 "additions" -- not the word that comes to mind; I think of "overlay" or "override". I raised this topic on the dev list for solrconfig.xml in 2021 and also mentioned solr.xml to

Re: [PR] SOLR-17153: CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState [solr]

2024-04-01 Thread via GitHub
dsmiley commented on PR #2363: URL: https://github.com/apache/solr/pull/2363#issuecomment-2030147402 Maybe in this PR or another we'll add a test like you (Mark) describe to ensure that CloudSolrClient directs requests to Solr in all circumstances (giving up on smart routing to a core if th

Re: [PR] SOLR-17220 - Make the SolrZkClient thread as a daemon thread [solr]

2024-04-01 Thread via GitHub
dsmiley commented on PR #2376: URL: https://github.com/apache/solr/pull/2376#issuecomment-2030090513 > Spark should actually call the SolrZkClient.close right? Yes. We aren't Spark experts here, but we are Solr experts :-). If you don't know about lifecycle matters in Spark the

[jira] [Created] (SOLR-17221) Http2SolrClient merges case sensitive solr params

2024-04-01 Thread Yue Yu (Jira)
Yue Yu created SOLR-17221: - Summary: Http2SolrClient merges case sensitive solr params Key: SOLR-17221 URL: https://issues.apache.org/jira/browse/SOLR-17221 Project: Solr Issue Type: Bug Securi

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached - Initial impl [solr]

2024-04-01 Thread via GitHub
gus-asf commented on PR #2379: URL: https://github.com/apache/solr/pull/2379#issuecomment-2029799436 One thing folks may want to review is the addition of synchronization around manipulations of HttpShardHandler#responseCancelableMap which were necessary to avoid CME such as: ``` {

[PR] Deprecate snapshotscli.sh in favour of bin/solr sub commands. [solr]

2024-04-01 Thread via GitHub
epugh opened a new pull request, #2381: URL: https://github.com/apache/solr/pull/2381 https://issues.apache.org/jira/browse/SOLR-17180 # Description Migrating some commands that are nested in the rather unknown `snapshotscli.sh` into `bin/solr` as commands. #

[jira] [Resolved] (SOLR-17181) Performance degradation matching glob patterns for fields

2024-04-01 Thread Justin Sweeney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Sweeney resolved SOLR-17181. --- Resolution: Fixed > Performance degradation matching glob patterns for fields > -