jdyer1 commented on code in PR #2374:
URL: https://github.com/apache/solr/pull/2374#discussion_r1546681105
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##########
@@ -469,6 +531,23 @@ protected String
allProcessorSupportedContentTypesCommaDelimited(
.collect(Collectors.joining(", "));
}
+ protected static class HttpSolrClientCancellable implements Cancellable {
Review Comment:
Yes I fully agree we should deprecate and replace the existing method, but
we will need to keep the old API around for 9.x. I am interested in taking a
closer look at SOLR-14763 and I appreciate your pointing me to that. But in
any case I would like to do that separately from this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
