HoustonPutman opened a new pull request, #2384:
URL: https://github.com/apache/solr/pull/2384

   This actually logs the correct stack trace for an exception caught in the 
ExecutorUtil.
   
   It also provides the correct ordering of "causes" unlike the way it was 
previously implemented, where the "cause" was actually the thread that called 
the Executor. Now the "cause" is the error in the executor, and the base 
exception is the thread that called the ExecutorUtil.
   
   It may look strange that we always use an `Exception` class, but this is ok 
since these exceptions that we are copying are only made a few lines up and are 
always of class `Exception`. (They aren't real exceptions, they are merely 
storing the stackTrace of how the original thread called the Executor, or the 
tree of executor calls). Therefore, no information is being lost here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to