[jira] [Resolved] (SOLR-16403) INACTIVE shards should be deleted periodically

2024-03-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16403. - Fix Version/s: 9.6.0 Resolution: Fixed > INACTIVE shards should be deleted periodically >

[jira] [Commented] (SOLR-16403) INACTIVE shards should be deleted periodically

2024-03-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827314#comment-17827314 ] ASF subversion and git services commented on SOLR-16403: Commit 4

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-03-14 Thread via GitHub
dsmiley commented on PR #2259: URL: https://github.com/apache/solr/pull/2259#issuecomment-1998742427 Instead of simply interrupting the threads, shouldn't we also join on them? Should that be in an AfterClass -- is it a problem between each test? note: you don't need to gather a Set to

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-03-14 Thread via GitHub
dsmiley commented on PR #2259: URL: https://github.com/apache/solr/pull/2259#issuecomment-1998729601 @jdyer1 Lets use a PR to collaborate on workaroundToReleaseThreads_noClosableUntilJava21. Getting all threads and interrupting each is a hack I'd like to try and avoid. I don't recall any

[PR] SOLR-17203 fix calculation for CpuAllowedLimit [solr]

2024-03-14 Thread via GitHub
gus-asf opened a new pull request, #2347: URL: https://github.com/apache/solr/pull/2347 https://issues.apache.org/jira/browse/SOLR-17203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Created] (SOLR-17203) CPU not calculated correctly in ThreadCpuTimer

2024-03-14 Thread Gus Heck (Jira)
Gus Heck created SOLR-17203: --- Summary: CPU not calculated correctly in ThreadCpuTimer Key: SOLR-17203 URL: https://issues.apache.org/jira/browse/SOLR-17203 Project: Solr Issue Type: Bug Secur

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-03-14 Thread via GitHub
madrob commented on code in PR #1768: URL: https://github.com/apache/solr/pull/1768#discussion_r1525478638 ## solr/bin/solr.cmd: ## @@ -544,14 +544,13 @@ IF "%1"=="-t" goto set_solr_data_dir IF "%1"=="-solr.home" goto set_solr_home_dir IF "%1"=="-e" goto set_example IF "%1"==

Re: [PR] Tests: avoid NPE in JettySolrRunner lifeCycleStopped [solr]

2024-03-14 Thread via GitHub
dsmiley merged PR #2337: URL: https://github.com/apache/solr/pull/2337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[PR] Update dependency com.fasterxml.jackson:jackson-bom to v2.16.2 [solr]

2024-03-14 Thread via GitHub
solrbot opened a new pull request, #2346: URL: https://github.com/apache/solr/pull/2346 This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [com.fasterxml.jackson:jackson-bom](https://togithub.com/FasterXML/jackson-bom)

[jira] [Updated] (SOLR-16403) INACTIVE shards should be deleted periodically

2024-03-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16403: Description: Have a periodic mechanism to delete state=INACTIVE shards. The implementation is a C

[jira] [Updated] (SOLR-16403) INACTIVE shards should be deleted periodically

2024-03-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16403: Description: Have a periodic mechanism to delete state=INACTIVE shards. The implementation is a C

[jira] [Updated] (SOLR-16403) INACTIVE shards should be deleted periodically

2024-03-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16403: Summary: INACTIVE shards should be deleted periodically (was: SPLITSHARD should delete the parent

[jira] [Commented] (SOLR-16403) SPLITSHARD should delete the parent shard after success

2024-03-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827237#comment-17827237 ] David Smiley commented on SOLR-16403: - On second thought; I'm going to retitle this,

[jira] [Commented] (SOLR-16403) SPLITSHARD should delete the parent shard after success

2024-03-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827236#comment-17827236 ] David Smiley commented on SOLR-16403: - Whoops; I don't think that PR should be using

Re: [PR] SOLR-16403: Cluster Singleton to remove inactive Shards [solr]

2024-03-14 Thread via GitHub
dsmiley merged PR #1926: URL: https://github.com/apache/solr/pull/1926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16403) SPLITSHARD should delete the parent shard after success

2024-03-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827227#comment-17827227 ] ASF subversion and git services commented on SOLR-16403: Commit c

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-03-14 Thread via GitHub
dsmiley commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-1998300785 Glad that you did the compression testing manually! I think at this point the PR just needs a few method/field renames to reflect to not confuse a SolrClient with an HttpClient. And there

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-03-14 Thread via GitHub
dsmiley commented on code in PR #2276: URL: https://github.com/apache/solr/pull/2276#discussion_r1525398141 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -261,22 +260,23 @@ public String getMessage() { } } - private static HttpClient createHtt

[jira] [Commented] (SOLR-15730) Modularize SolrJ

2024-03-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827196#comment-17827196 ] David Smiley commented on SOLR-15730: - SolrJ gained Jackson recently, related to the

[jira] [Commented] (SOLR-17106) LBSolrClient: Make it configurable to remove zombie ping checks

2024-03-14 Thread Aparna Suresh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827178#comment-17827178 ] Aparna Suresh commented on SOLR-17106: -- Hi [~hossman] , I made the changes you requ

[jira] [Commented] (SOLR-599) Lightweight SolrJ client

2024-03-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827171#comment-17827171 ] Jan Høydahl commented on SOLR-599: -- {quote}I think so, but we might need a Load Balancing

[jira] [Created] (SOLR-17202) Change SolrJ maven coordinates (10.x)

2024-03-14 Thread Jira
Jan Høydahl created SOLR-17202: -- Summary: Change SolrJ maven coordinates (10.x) Key: SOLR-17202 URL: https://issues.apache.org/jira/browse/SOLR-17202 Project: Solr Issue Type: Sub-task

[jira] [Commented] (SOLR-599) Lightweight SolrJ client

2024-03-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827151#comment-17827151 ] ASF subversion and git services commented on SOLR-599: -- Commit 7eb38d5

[jira] [Commented] (SOLR-599) Lightweight SolrJ client

2024-03-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827148#comment-17827148 ] ASF subversion and git services commented on SOLR-599: -- Commit c8c6001

Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-14 Thread via GitHub
janhoy commented on code in PR #2345: URL: https://github.com/apache/solr/pull/2345#discussion_r1524517935 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java: ## @@ -19,10 +19,7 @@ import java.io.Closeable; /** - * Factory interface for co

[jira] [Created] (SOLR-17201) Make Http2SolrClients not experimental

2024-03-14 Thread Jira
Jan Høydahl created SOLR-17201: -- Summary: Make Http2SolrClients not experimental Key: SOLR-17201 URL: https://issues.apache.org/jira/browse/SOLR-17201 Project: Solr Issue Type: Improvement