dsmiley commented on PR #2259: URL: https://github.com/apache/solr/pull/2259#issuecomment-1998742427
Instead of simply interrupting the threads, shouldn't we also join on them? Should that be in an AfterClass -- is it a problem between each test? note: you don't need to gather a Set to then iterate; you can call `forEach` on the stream to do whatever you want to do. I don't think using a Set (for uniqueness) is necessary here either. What is the GC accomplishing? I was looking again at all those test overrides that call super. I removed them locally and I was able to run at the CLI and IntelliJ and it ran all the intherited tests. This pattern is done elsewhere like SolrExampleTests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
