[jira] [Updated] (SOLR-16367) Umbrella: Migrate away from Apache HttpClient.

2023-11-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16367: Fix Version/s: main (10.0) Priority: Blocker (was: Major) > Umbrella: Migrate away from A

Re: [PR] SOLR-10653: leader to replica updates fail on UUIDField [solr]

2023-11-20 Thread via GitHub
dsmiley commented on code in PR #2078: URL: https://github.com/apache/solr/pull/2078#discussion_r1399806266 ## solr/core/src/test/org/apache/solr/update/UuidAtomicUpdateTest.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] SOLR-10653: leader to replica updates fail on UUIDField [solr]

2023-11-20 Thread via GitHub
dsmiley commented on code in PR #2078: URL: https://github.com/apache/solr/pull/2078#discussion_r1399793798 ## solr/modules/extraction/src/test/org/apache/solr/handler/extraction/TestXLSXResponseWriter.java: ## @@ -38,8 +38,10 @@ import org.apache.solr.search.SolrReturnFields;

Re: [PR] SOLR-17076: Optimize `OrderedNodePlacementPlugin#getAllReplicasOnNode` [solr]

2023-11-20 Thread via GitHub
patsonluk commented on code in PR #2076: URL: https://github.com/apache/solr/pull/2076#discussion_r1399517132 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java: ## @@ -515,6 +521,7 @@ public final void removeReplica(Replica replica)

Re: [PR] SOLR-17076: Optimize `OrderedNodePlacementPlugin#getAllReplicasOnNode` [solr]

2023-11-20 Thread via GitHub
patsonluk commented on code in PR #2076: URL: https://github.com/apache/solr/pull/2076#discussion_r1399517132 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java: ## @@ -515,6 +521,7 @@ public final void removeReplica(Replica replica)

[PR] Add support for optional DBQ expansion. [solr-sandbox]

2023-11-20 Thread via GitHub
sigram opened a new pull request, #91: URL: https://github.com/apache/solr-sandbox/pull/91 This PR adds a boolean config option `expandDbq` (defaults to true) that allows to control whether Delete-By-Query should be expanded on the source-side into a series of Delete-By-Ids. There are trade

Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

2023-11-20 Thread via GitHub
dsmiley commented on code in PR #2084: URL: https://github.com/apache/solr/pull/2084#discussion_r1399267463 ## solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/RejoinLeaderElectionPayload.java: ## @@ -26,13 +26,9 @@ public class RejoinLeaderElectionPayload implemen

Re: [PR] SOLR-17079: Fix OverseerCollectionConfigSetProcessorTest [solr]

2023-11-20 Thread via GitHub
pvcnt commented on code in PR #2085: URL: https://github.com/apache/solr/pull/2085#discussion_r1399258455 ## solr/core/src/test/org/apache/solr/cloud/OverseerCollectionConfigSetProcessorTest.java: ## @@ -131,7 +130,7 @@ public class OverseerCollectionConfigSetProcessorTest exte

[jira] [Commented] (SOLR-17079) Allow to declare replica placement plugins in solr.xml

2023-11-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788034#comment-17788034 ] ASF subversion and git services commented on SOLR-17079: Commit 9

Re: [PR] SOLR-17079: Fix OverseerCollectionConfigSetProcessorTest [solr]

2023-11-20 Thread via GitHub
dsmiley merged PR #2085: URL: https://github.com/apache/solr/pull/2085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17079: Fix OverseerCollectionConfigSetProcessorTest [solr]

2023-11-20 Thread via GitHub
dsmiley commented on code in PR #2085: URL: https://github.com/apache/solr/pull/2085#discussion_r1399255514 ## solr/core/src/test/org/apache/solr/cloud/OverseerCollectionConfigSetProcessorTest.java: ## @@ -131,7 +130,7 @@ public class OverseerCollectionConfigSetProcessorTest ex

[jira] [Assigned] (SOLR-17081) TestXLSXResponseWriter test failures on CI

2023-11-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-17081: --- Assignee: David Smiley > TestXLSXResponseWriter test failures on CI > --

[jira] [Commented] (SOLR-17081) TestXLSXResponseWriter test failures on CI

2023-11-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788017#comment-17788017 ] David Smiley commented on SOLR-17081: - I reported this to Uv at Crave and it's becaus

Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]

2023-11-20 Thread via GitHub
cpoerschke commented on PR #2071: URL: https://github.com/apache/solr/pull/2071#issuecomment-1819085178 > ... Btw, there are tests in `TestXLSXResponseWriter` failing in CI, but I cannot reproduce locally (and it does not really seem related to my change). Filed https://issues.apache.

Re: [PR] SOLR-17050: Save models as compacted json [solr]

2023-11-20 Thread via GitHub
cpoerschke commented on PR #2030: URL: https://github.com/apache/solr/pull/2030#issuecomment-1819084154 > The `solr:modules:extraction:test` CI failure seems unrelated/pre-existing/environmental e.g. https://lists.apache.org/thread/fgmlyf8smtj8qyy14466bqfjhsqhqqjs -- cannot reproduce local

[jira] [Created] (SOLR-17081) TestXLSXResponseWriter test failures on CI

2023-11-20 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-17081: -- Summary: TestXLSXResponseWriter test failures on CI Key: SOLR-17081 URL: https://issues.apache.org/jira/browse/SOLR-17081 Project: Solr Issue Typ

Re: [PR] SOLR-17050: Save models as compacted json [solr]

2023-11-20 Thread via GitHub
cpoerschke commented on code in PR #2030: URL: https://github.com/apache/solr/pull/2030#discussion_r1399162976 ## solr/CHANGES.txt: ## @@ -96,6 +96,8 @@ Improvements * SOLR-17041: Make CommitTracker currentTlogSize lazy (Alex Deparvu) +* SOLR-17050: Use compact JSON for Lea

Re: [PR] SOLR-17050: Save models as compacted json [solr]

2023-11-20 Thread via GitHub
holysleeper commented on PR #2030: URL: https://github.com/apache/solr/pull/2030#issuecomment-1819003485 I did an update for a failed tidy check. Also @cpoerschke I did a commit with your suggestion. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] SOLR-17050: Save models as compacted json [solr]

2023-11-20 Thread via GitHub
cpoerschke commented on code in PR #2030: URL: https://github.com/apache/solr/pull/2030#discussion_r1399149645 ## solr/modules/ltr/src/test/org/apache/solr/ltr/store/rest/TestModelManagerPersistence.java: ## @@ -137,6 +139,24 @@ public void testFeaturePersistence() throws Except

Re: [PR] Producer metrics [solr-sandbox]

2023-11-20 Thread via GitHub
sigram commented on code in PR #87: URL: https://github.com/apache/solr-sandbox/pull/87#discussion_r1399005175 ## crossdc-producer/src/main/java/org/apache/solr/update/processor/MirroringUpdateProcessor.java: ## @@ -107,18 +110,24 @@ UpdateRequest createMirrorRequest() { do

Re: [PR] RetryQueueIntegrationTest failures [solr-sandbox]

2023-11-20 Thread via GitHub
sigram merged PR #90: URL: https://github.com/apache/solr-sandbox/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] SOLR-17079: Fix OverseerCollectionConfigSetProcessorTest [solr]

2023-11-20 Thread via GitHub
pvcnt commented on code in PR #2085: URL: https://github.com/apache/solr/pull/2085#discussion_r1398796344 ## solr/core/src/test/org/apache/solr/cloud/OverseerCollectionConfigSetProcessorTest.java: ## @@ -131,7 +130,7 @@ public class OverseerCollectionConfigSetProcessorTest exte

Re: [PR] SOLR-17079: Allow to declare replica placement plugins in solr.xml [solr]

2023-11-20 Thread via GitHub
pvcnt commented on PR #2071: URL: https://github.com/apache/solr/pull/2071#issuecomment-1818435207 Ooops, sorry about that. Is there a view of all tests failures in a CI run? Or is there a way to configure that? I know that in Jenkins we can have a specific view of all failing tests instead

[PR] SOLR-17079: Fix OverseerCollectionConfigSetProcessorTest [solr]

2023-11-20 Thread via GitHub
pvcnt opened a new pull request, #2085: URL: https://github.com/apache/solr/pull/2085 https://issues.apache.org/jira/browse/SOLR-17079 # Description Please provide a short description of the changes you're making with this pull request. # Solution Plea