cpoerschke commented on code in PR #2030:
URL: https://github.com/apache/solr/pull/2030#discussion_r1399149645
##########
solr/modules/ltr/src/test/org/apache/solr/ltr/store/rest/TestModelManagerPersistence.java:
##########
@@ -137,6 +139,24 @@ public void testFeaturePersistence() throws Exception {
assertJQ(ManagedModelStore.REST_END_POINT, "/models/==[]");
}
+ @Test
+ public void testModelIsStoredCompact() throws Exception {
Review Comment:
minor: rename to reflect that not just model storage compactness is tested
```suggestion
public void testIsStoredCompact() throws Exception {
```
or
```suggestion
public void testFeaturesAndModelAreStoredCompact() throws Exception {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
