dsmiley commented on code in PR #2085:
URL: https://github.com/apache/solr/pull/2085#discussion_r1399255514
##########
solr/core/src/test/org/apache/solr/cloud/OverseerCollectionConfigSetProcessorTest.java:
##########
@@ -131,7 +130,7 @@ public class OverseerCollectionConfigSetProcessorTest
extends SolrTestCaseJ4 {
private static HttpClient httpClientMock;
@SuppressWarnings("rawtypes")
- private static PlacementPluginFactory placementPluginFactoryMock;
+ private final PlacementPluginFactory placementPluginFactory = new
SimplePlacementFactory();
Review Comment:
I know this is a matter of opinion, but I recommend using mocks *sparingly*.
I generally avoid altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
