Re: [PR] Add serialization unit test. [solr-sandbox]

2023-10-11 Thread via GitHub
markrmiller merged PR #66: URL: https://github.com/apache/solr-sandbox/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[PR] Bump golang.org/x/net from 0.15.0 to 0.17.0 [solr-operator]

2023-10-11 Thread via GitHub
dependabot[bot] opened a new pull request, #644: URL: https://github.com/apache/solr-operator/pull/644 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0. Commits https://github.com/golang/net/commit/b225e7ca6dde1ef5a5ae5ce922861bda011cfabd";>b225e7c

Re: [PR] Gradle 8.4 [solr]

2023-10-11 Thread via GitHub
risdenk commented on PR #1997: URL: https://github.com/apache/solr/pull/1997#issuecomment-1758518496 Planning to do the same as Lucene - merge as separate commits and put tidy commit in `.git-blame-ignore-revs` -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774236#comment-17774236 ] Kevin Risden commented on SOLR-17026: - https://github.com/apache/solr/pull/1997 > Up

[jira] [Updated] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17026: Status: Patch Available (was: Open) > Upgrade to Gradle 8.4 > - > >

[jira] [Created] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-11 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-17026: --- Summary: Upgrade to Gradle 8.4 Key: SOLR-17026 URL: https://issues.apache.org/jira/browse/SOLR-17026 Project: Solr Issue Type: Task Security Level: Publi

Re: [PR] SOLR-17015: Test and fix bug in MoveReplicaCmd for PRS collections [solr]

2023-10-11 Thread via GitHub
magibney commented on PR #1986: URL: https://github.com/apache/solr/pull/1986#issuecomment-1758506454 I'm planning to merge this soon (after #1964). The main code fixes a clear bug that only affects PRS. The test code is considerably more robust in stressing conditions that could cause move

Re: [PR] SOLR-16038: Rename PackageStore as Filestore [solr]

2023-10-11 Thread via GitHub
janhoy commented on PR #1908: URL: https://github.com/apache/solr/pull/1908#issuecomment-1758487117 Yea, probably concentrate on the rename for now 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Gradle 8.4 [solr]

2023-10-11 Thread via GitHub
risdenk commented on PR #1997: URL: https://github.com/apache/solr/pull/1997#issuecomment-1758485081 Gradle 8.4 is done in Lucene so going to make sure this is all ready to go here too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] SOLR-11535: Fix race condition in singleton-per-collection StateWatcher creation [solr]

2023-10-11 Thread via GitHub
magibney commented on PR #1964: URL: https://github.com/apache/solr/pull/1964#issuecomment-1758451885 Having lived with these changes for a bit, I plan to commit this within the next day or two, pending feedback. Proposed CHANGES.txt entry: ``` * SOLR-11535: Fix race condition in singl

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2023-10-11 Thread via GitHub
risdenk commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-1758409816 @magibney @dsmiley I pushed the revert of retryOnConnLoss - basically its just ignored now in [44399c7](https://github.com/apache/solr/pull/760/commits/44399c710f639350c8c635bb3458024699a9c0a5

[PR] Removing list.to array calls with pre sized arrays [solr]

2023-10-11 Thread via GitHub
renatoh opened a new pull request, #2003: URL: https://github.com/apache/solr/pull/2003 see discussing on old PR: https://github.com/apache/solr/pull/1873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Comment Edited] (SOLR-17018) LTR queries producing out of memory issues

2023-10-11 Thread rajanimaski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774195#comment-17774195 ] rajanimaski edited comment on SOLR-17018 at 10/11/23 6:48 PM: -

[jira] [Comment Edited] (SOLR-17018) LTR queries producing out of memory issues

2023-10-11 Thread rajanimaski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774195#comment-17774195 ] rajanimaski edited comment on SOLR-17018 at 10/11/23 6:45 PM: -

[jira] [Commented] (SOLR-17018) LTR queries producing out of memory issues

2023-10-11 Thread rajanimaski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774195#comment-17774195 ] rajanimaski commented on SOLR-17018:  ok figured it is lengthy queries "q" having man

[jira] [Updated] (SOLR-17018) LTR queries producing out of memory issues

2023-10-11 Thread rajanimaski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] rajanimaski updated SOLR-17018: --- Attachment: image-2023-10-11-14-38-43-351.png > LTR queries producing out of memory issues >

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2023-10-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774179#comment-17774179 ] ASF subversion and git services commented on SOLR-16825: Commit 6

Re: [PR] Removing List.toArray calls with pre-sized Arrays [solr]

2023-10-11 Thread via GitHub
renatoh closed pull request #1873: Removing List.toArray calls with pre-sized Arrays URL: https://github.com/apache/solr/pull/1873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2023-10-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774178#comment-17774178 ] ASF subversion and git services commented on SOLR-16825: Commit b

Re: [PR] SOLR-16825: Migrate v2 definitions to 'api' module, pt 6 [solr]

2023-10-11 Thread via GitHub
gerlowskija merged PR #1978: URL: https://github.com/apache/solr/pull/1978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-17024) Remove support for deprecated "collection-default clusterprop syntax

2023-10-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774156#comment-17774156 ] Jason Gerlowski commented on SOLR-17024: Not quite sure what backcompat requires

Re: [PR] [experimental] start BERT module [solr]

2023-10-11 Thread via GitHub
cpoerschke commented on code in PR #1073: URL: https://github.com/apache/solr/pull/1073#discussion_r1355447241 ## solr/modules/bert/build.gradle: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. S

[PR] SOLR-17024: Remove deprecated 'collectionDefaults' support [solr]

2023-10-11 Thread via GitHub
gerlowskija opened a new pull request, #2002: URL: https://github.com/apache/solr/pull/2002 https://issues.apache.org/jira/browse/SOLR-17024 # Description Solr 7.5 replaced the 'collectionDefaults: {...}' clusterprop convention with the additionally nested `defaults: collec

Re: [PR] No Jira: some release script tweaks [solr]

2023-10-11 Thread via GitHub
stillalex commented on PR #1976: URL: https://github.com/apache/solr/pull/1976#issuecomment-1758091925 > I don't see anything wrong here... I mean you should delete the rc1 artifacts, not sure why you said n there, but they can be deleted manually afterwards. Is there a reason you wanted to

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
epugh commented on code in PR #1999: URL: https://github.com/apache/solr/pull/1999#discussion_r1355343058 ## solr/packaging/test/test_opennlp.bats: ## @@ -0,0 +1,110 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor li

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
epugh commented on PR #1999: URL: https://github.com/apache/solr/pull/1999#issuecomment-1758056050 I think the first draft is done, and it "works". There are some caveats and things to be figured out, like the `onnxruntime_gpu` versus `onnxruntime` issue. Based on my work so far, we defi

Re: [PR] No Jira: some release script tweaks [solr]

2023-10-11 Thread via GitHub
HoustonPutman commented on PR #1976: URL: https://github.com/apache/solr/pull/1976#issuecomment-1758050203 I don't see anything wrong here... I mean you should delete the rc1 artifacts, not sure why you said `n` there, but they can be deleted manually afterwards. Is there a reason you wante

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
epugh commented on code in PR #1999: URL: https://github.com/apache/solr/pull/1999#discussion_r1355315707 ## versions.props: ## @@ -70,3 +70,4 @@ org.semver4j:semver4j=5.2.1 org.slf4j:*=2.0.9 org.xerial.snappy:snappy-java=1.1.10.5 software.amazon.awssdk:*=2.20.155 +org.apache

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
epugh commented on PR #1999: URL: https://github.com/apache/solr/pull/1999#issuecomment-1758028188 @jzonthemtn did open https://issues.apache.org/jira/browse/OPENNLP-1515, but that will require a release of OpenNLP before we can piggy back on it -- This is an automated message from the A

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
jzonthemtn commented on code in PR #1999: URL: https://github.com/apache/solr/pull/1999#discussion_r1355287827 ## versions.props: ## @@ -70,3 +70,4 @@ org.semver4j:semver4j=5.2.1 org.slf4j:*=2.0.9 org.xerial.snappy:snappy-java=1.1.10.5 software.amazon.awssdk:*=2.20.155 +org.a

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
jzonthemtn commented on code in PR #1999: URL: https://github.com/apache/solr/pull/1999#discussion_r1355279288 ## solr/packaging/test/test_opennlp.bats: ## @@ -0,0 +1,110 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribut

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
jzonthemtn commented on code in PR #1999: URL: https://github.com/apache/solr/pull/1999#discussion_r1355279288 ## solr/packaging/test/test_opennlp.bats: ## @@ -0,0 +1,110 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribut

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
jzonthemtn commented on code in PR #1999: URL: https://github.com/apache/solr/pull/1999#discussion_r1355279288 ## solr/packaging/test/test_opennlp.bats: ## @@ -0,0 +1,110 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribut

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
epugh commented on code in PR #1999: URL: https://github.com/apache/solr/pull/1999#discussion_r1355278242 ## solr/packaging/test/test_opennlp.bats: ## @@ -0,0 +1,110 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor li

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
epugh commented on code in PR #1999: URL: https://github.com/apache/solr/pull/1999#discussion_r1355275354 ## solr/packaging/test/test_opennlp.bats: ## @@ -0,0 +1,110 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor li

Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2023-10-11 Thread via GitHub
risdenk commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1355269801 ## solr/modules/aws-secret-provider/src/test/org/apache/solr/secret/zk/AWSSecretCredentialsProviderTest.java: ## @@ -0,0 +1,440 @@ +/* + * Licensed to the Apache Software

Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2023-10-11 Thread via GitHub
laminelam commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1355263209 ## settings.gradle: ## @@ -55,6 +55,7 @@ include "solr:packaging" include "solr:distribution" include "solr:docker" include "solr:prometheus-exporter" +include "solr:

Re: [PR] SOLR-16038: Rename PackageStore as Filestore [solr]

2023-10-11 Thread via GitHub
epugh commented on PR #1908: URL: https://github.com/apache/solr/pull/1908#issuecomment-1757978785 Two thoughts on your last message: 1) should we label it experimental so we can make changes without worrying about back compatiblity if we think that there is still a lot of work to be

Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2023-10-11 Thread via GitHub
laminelam commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1355262469 ## solr/modules/aws-secret-provider/src/test/org/apache/solr/secret/zk/AWSSecretCredentialsProviderTest.java: ## @@ -0,0 +1,441 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2023-10-11 Thread via GitHub
risdenk commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-1757978274 I can take care of that hopefully today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2023-10-11 Thread via GitHub
magibney commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-1757964761 > I propose we make the loss of the reconnect boolean its own PR, plus the methods that shielded use of ZkCmdExecutor. That will make this effort here more independently reviewable and would

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
epugh commented on PR #1999: URL: https://github.com/apache/solr/pull/1999#issuecomment-1757962736 also, i am seeing two errors on looking up licenses... ``` Execution failed for task ':solr:modules:analysis-extras:validateJarLicenses'. > Certain license/ notice files are missin

Re: [PR] SOLR-17023: Use Modern NLP Models from Apache OpenNLP with Solr [solr]

2023-10-11 Thread via GitHub
epugh commented on PR #1999: URL: https://github.com/apache/solr/pull/1999#issuecomment-1757960986 @risdenk @jzonthemtn so, any ideas how to force the `onnxruntime` instead of the `onnxruntime_gpu`? I regenerated the licenses, and noticed that it created a "onnxruntime_gpu-1.14.0.jar.sha1

Re: [PR] SOLR-17022: Support for glob patterns for fields in Export handler, Stream handler and with SelectStream streaming expression [solr]

2023-10-11 Thread via GitHub
magibney commented on code in PR #1996: URL: https://github.com/apache/solr/pull/1996#discussion_r1355222328 ## solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java: ## @@ -844,4 +844,61 @@ public String getMessage() { return "Early Client Disconnect";

Re: [PR] SOLR-17022: Support for glob patterns for fields in Export handler, Stream handler and with SelectStream streaming expression [solr]

2023-10-11 Thread via GitHub
epugh commented on code in PR #1996: URL: https://github.com/apache/solr/pull/1996#discussion_r1355179911 ## solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java: ## @@ -844,4 +844,61 @@ public String getMessage() { return "Early Client Disconnect"; }

Re: [PR] SOLR-17022: Support for glob patterns for fields in Export handler, Stream handler and with SelectStream streaming expression [solr]

2023-10-11 Thread via GitHub
justinrsweeney commented on PR #1996: URL: https://github.com/apache/solr/pull/1996#issuecomment-1757895968 > This seems like a very useful feature! I also like the establishing parity in how things work. Will you make sure to update ref guide? Yup, I can update the ref guide before m

Re: [PR] SOLR-17022: Support for glob patterns for fields in Export handler, Stream handler and with SelectStream streaming expression [solr]

2023-10-11 Thread via GitHub
risdenk commented on code in PR #1996: URL: https://github.com/apache/solr/pull/1996#discussion_r1355160787 ## solr/solrj/src/test/org/apache/solr/common/util/TestGlobPatternUtil.java: ## @@ -0,0 +1,17 @@ +package org.apache.solr.common.util; Review Comment: Looks like missi

Re: [PR] SOLR-17022: Support for glob patterns for fields in Export handler, Stream handler and with SelectStream streaming expression [solr]

2023-10-11 Thread via GitHub
justinrsweeney commented on code in PR #1996: URL: https://github.com/apache/solr/pull/1996#discussion_r1355153153 ## solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java: ## @@ -844,4 +844,61 @@ public String getMessage() { return "Early Client Disconnect"

Re: [PR] SOLR-17022: Support for glob patterns for fields in Export handler, Stream handler and with SelectStream streaming expression [solr]

2023-10-11 Thread via GitHub
justinrsweeney commented on code in PR #1996: URL: https://github.com/apache/solr/pull/1996#discussion_r1355137227 ## solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java: ## @@ -27,9 +27,14 @@ import java.io.PrintWriter; import java.lang.invoke.MethodHandles;

Re: [PR] SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory [solr]

2023-10-11 Thread via GitHub
stillalex commented on PR #1856: URL: https://github.com/apache/solr/pull/1856#issuecomment-1757840635 proposed CHANGES.txt ``` Extend Solr client tracing coverage to both Jetty Client and Apache HttpClient ``` -- This is an automated message from the Apache Git Service.

Re: [PR] SOLR-16825: Migrate v2 definitions to 'api' module, pt 6 [solr]

2023-10-11 Thread via GitHub
gerlowskija commented on PR #1978: URL: https://github.com/apache/solr/pull/1978#issuecomment-1757673021 I think I'll go with "store" as the term for now. I kindof agree with Eric that "resource" is maybe too generic? It's also an overloaded term, as JAX-RS/Jersey calls API classes "resou

[jira] [Commented] (SOLR-17025) Upgrade to Jetty 9.4.53 on branch_8_11

2023-10-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774057#comment-17774057 ] ASF subversion and git services commented on SOLR-17025: Commit e

[jira] [Updated] (SOLR-17025) Upgrade to Jetty 9.4.53 on branch_8_11

2023-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17025: Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade to Jetty 9.4.53 on bra

[jira] [Updated] (SOLR-17025) Upgrade to Jetty 9.4.53 on branch_8_11

2023-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17025: Status: Patch Available (was: Open) > Upgrade to Jetty 9.4.53 on branch_8_11 > ---

[jira] [Commented] (SOLR-17025) Upgrade to Jetty 9.4.53 on branch_8_11

2023-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774056#comment-17774056 ] Kevin Risden commented on SOLR-17025: - https://github.com/apache/lucene-solr/pull/268

[jira] [Updated] (SOLR-17025) Upgrade to Jetty 9.4.53 on branch_8_11

2023-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17025: Fix Version/s: 8.11.3 > Upgrade to Jetty 9.4.53 on branch_8_11 > --

[jira] [Created] (SOLR-17025) Upgrade to Jetty 9.4.53 on branch_8_11

2023-10-11 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-17025: --- Summary: Upgrade to Jetty 9.4.53 on branch_8_11 Key: SOLR-17025 URL: https://issues.apache.org/jira/browse/SOLR-17025 Project: Solr Issue Type: Task Secu

[jira] [Created] (SOLR-17024) Remove support for deprecated "collection-default clusterprop syntax

2023-10-11 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17024: -- Summary: Remove support for deprecated "collection-default clusterprop syntax Key: SOLR-17024 URL: https://issues.apache.org/jira/browse/SOLR-17024 Project: Solr