magibney commented on PR #1964: URL: https://github.com/apache/solr/pull/1964#issuecomment-1758451885
Having lived with these changes for a bit, I plan to commit this within the next day or two, pending feedback. Proposed CHANGES.txt entry: ``` * SOLR-11535: Fix race condition in singleton-per-collection StateWatcher creation (Michael Gibney) ``` I'm inclined to put this under "Bugs". Even though it's a bug that often doesn't often manifest in a visible way, the essence of this issue is that ZkStateReader has been leaking redundant `StateWatcher`s that, once present, re-register themselves in perpetuity as long as the collection is still watched ... which definitely sounds to me like a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org