magibney commented on PR #1986: URL: https://github.com/apache/solr/pull/1986#issuecomment-1758506454
I'm planning to merge this soon (after #1964). The main code fixes a clear bug that only affects PRS. The test code is considerably more robust in stressing conditions that could cause moves to fail. There's little point to letting this bake on main, since the (minimal) core code changes are definitely solid. The only risk from merging this is spurious test failures. I'll keep an eye on builds after committing this and figure out how to proceed if we indeed hit any new test failures. Proposed CHANGES.txt entry: ``` * SOLR-17015: Test and fix bug in MoveReplicaCmd for PRS collections (Michael Gibney) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org