[GitHub] [solr] dsmiley commented on pull request #1504: SOLR-7609 ShardSplitTest NPE investigation

2023-04-20 Thread via GitHub
dsmiley commented on PR #1504: URL: https://github.com/apache/solr/pull/1504#issuecomment-1517240922 I appreciate the bulleted summary of your last comment very much. It will make a good commit message. I think this PR is in good shape. Proposed CHANGES.txt _(less sure on this)_:

[GitHub] [solr] tflobbe commented on pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
tflobbe commented on PR #1577: URL: https://github.com/apache/solr/pull/1577#issuecomment-1517074309 I've updated the code with a possible rename. the new validation of "maxReplicasPerShardInDomain" is not being used yet. Still, there is a need to improve javadocs and add something to th

[GitHub] [solr] patsonluk commented on pull request #1477: SOLR-16712: Simplify DocCollection ctor for PRS enabled collection

2023-04-20 Thread via GitHub
patsonluk commented on PR #1477: URL: https://github.com/apache/solr/pull/1477#issuecomment-1517068641 @noblepaul I have pushed the updates, it's using `AtomicReference` very similar to the `PrsSupplier`, but it does not fetch. The fetching is still done by the `PrsSupplier` but is only ca

[GitHub] [solr] HoustonPutman commented on pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
HoustonPutman commented on PR #1577: URL: https://github.com/apache/solr/pull/1577#issuecomment-1516993264 > Do keep in mind that "availabilityZone" is already doing the first level of spreading, and this configuration is only within one AZ (for racks, in your example). I did not rea

[GitHub] [solr] tflobbe commented on pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
tflobbe commented on PR #1577: URL: https://github.com/apache/solr/pull/1577#issuecomment-1516943262 I see. Do keep in mind that "availabilityZone" is already doing the first level of spreading, and this configuration is only within one AZ (for racks, in your example). I guess someone may w

[jira] [Commented] (SOLR-16758) GraphQuery Performing Slower in Solr 9

2023-04-20 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714749#comment-17714749 ] Michael Gibney commented on SOLR-16758: --- Thanks for reporting! Can you share some s

[GitHub] [solr] HoustonPutman commented on pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
HoustonPutman commented on PR #1577: URL: https://github.com/apache/solr/pull/1577#issuecomment-1516879031 > Let users configure the "spread", which is exactly what the PR is doing for now (new features such as the maxSkew could be added in the future) Yep 👍 > Make anti-affini

[jira] [Updated] (SOLR-16758) GraphQuery Performing Slower in Solr 9

2023-04-20 Thread Kira Traynor (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kira Traynor updated SOLR-16758: Description: We found that the changes made in SOLR-14185 with the GraphQuery slowed down the perf

[jira] [Created] (SOLR-16758) GraphQuery Performing Slower in Solr 9

2023-04-20 Thread Kira Traynor (Jira)
Kira Traynor created SOLR-16758: --- Summary: GraphQuery Performing Slower in Solr 9 Key: SOLR-16758 URL: https://issues.apache.org/jira/browse/SOLR-16758 Project: Solr Issue Type: Bug Secur

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
HoustonPutman commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1173011527 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -503,15 +534,199 @@ private String getNodeAZ(Node n, final Attri

[GitHub] [solr] tflobbe commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
tflobbe commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1172989171 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -503,15 +534,199 @@ private String getNodeAZ(Node n, final AttributeVa

[GitHub] [solr] tflobbe commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
tflobbe commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1172987083 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -503,15 +534,199 @@ private String getNodeAZ(Node n, final AttributeVa

[GitHub] [solr] tflobbe commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
tflobbe commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1172983143 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -503,15 +534,199 @@ private String getNodeAZ(Node n, final AttributeVa

[GitHub] [solr] tflobbe commented on pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
tflobbe commented on PR #1577: URL: https://github.com/apache/solr/pull/1577#issuecomment-1516808584 > I do think a different name would be more appropriate though. I see. I wasn't aware of the "spread" feature in Kubernetes, but yes, it does look closer to what I have here. I was act

[GitHub] [solr] patsonluk commented on pull request #1477: SOLR-16712: Simplify DocCollection ctor for PRS enabled collection

2023-04-20 Thread via GitHub
patsonluk commented on PR #1477: URL: https://github.com/apache/solr/pull/1477#issuecomment-1516770497 > @patsonluk as it is mutating an existing Object, there is a small period during which the state of a given replica is unpredictable . some replicas of the collection would fetch state fr

[GitHub] [solr-operator] HoustonPutman commented on issue #537: Slow restart of Solr Pod init_container cp-solr-xml chown

2023-04-20 Thread via GitHub
HoustonPutman commented on issue #537: URL: https://github.com/apache/solr-operator/issues/537#issuecomment-1516758452 Yeah reading more through it, it seems like the default functionality is "Always", so its weird that it wouldn't be working in the first place. I guess we need to keep the

[jira] [Commented] (SOLR-16757) Umbrella Ticket for Reading Solr CLI's for the Future

2023-04-20 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714700#comment-17714700 ] Eric Pugh commented on SOLR-16757: -- I've cast a wide net on the list of tickets to inclu

[GitHub] [solr] magibney commented on pull request #1440: SOLR-16691 : Use Jackson for JSON serialization

2023-04-20 Thread via GitHub
magibney commented on PR #1440: URL: https://github.com/apache/solr/pull/1440#issuecomment-1516725785 @noblepaul take a look at https://github.com/apache/solr/pull/513 -- in particular, the RawShimTextResponseWriter which together with TextResponseWriter (from which it is invoked) actually

[jira] [Updated] (SOLR-16757) Umbrella Ticket for Reading Solr CLI's for the Future

2023-04-20 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16757: - Summary: Umbrella Ticket for Reading Solr CLI's for the Future (was: Clean up Solr CLI's for the Future)

[jira] [Created] (SOLR-16757) Clean up Solr CLI's for the Future

2023-04-20 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16757: Summary: Clean up Solr CLI's for the Future Key: SOLR-16757 URL: https://issues.apache.org/jira/browse/SOLR-16757 Project: Solr Issue Type: Task Security Level

[jira] [Commented] (SOLR-16711) Seperate tools out of SolrCLI.java into their own files.

2023-04-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714698#comment-17714698 ] ASF subversion and git services commented on SOLR-16711: Commit f

[jira] [Resolved] (SOLR-16711) Seperate tools out of SolrCLI.java into their own files.

2023-04-20 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16711. -- Fix Version/s: main (10.0) 9.3 Resolution: Fixed > Seperate tools out of Solr

[jira] [Commented] (SOLR-16711) Seperate tools out of SolrCLI.java into their own files.

2023-04-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714696#comment-17714696 ] ASF subversion and git services commented on SOLR-16711: Commit 3

[GitHub] [solr] epugh merged pull request #1568: SOLR-16711: Extract SolrCLI tool implementations into their own package and classes (Take 2)

2023-04-20 Thread via GitHub
epugh merged PR #1568: URL: https://github.com/apache/solr/pull/1568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] bqcuong commented on a diff in pull request #1575: SOLR-16752 Reduce attack surface and size for Docker image

2023-04-20 Thread via GitHub
bqcuong commented on code in PR #1575: URL: https://github.com/apache/solr/pull/1575#discussion_r1171494844 ## solr/CHANGES.txt: ## @@ -91,6 +91,8 @@ Improvements /api/collections/collName/snapshots/snapshotName`, listed at `GET /api/collections/collName/snapshots`, and dele

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
HoustonPutman commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1172807490 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -503,15 +534,199 @@ private String getNodeAZ(Node n, final Attri

[jira] [Commented] (SOLR-16741) CLUSTERSTATUS API returns wrong value for state ,leader for PRS collections

2023-04-20 Thread Justin Sweeney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714642#comment-17714642 ] Justin Sweeney commented on SOLR-16741: --- Feel free to backport this to 9.2 for the

[jira] [Commented] (SOLR-16505) Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2

2023-04-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714633#comment-17714633 ] Bence Szabó commented on SOLR-16505: I was looking at this issue and I think I could

[GitHub] [solr] potenzal opened a new pull request, #1578: SOLR-16756: SchemaCodecFactory, add test coverage for getKnnVectorsFormatForField

2023-04-20 Thread via GitHub
potenzal opened a new pull request, #1578: URL: https://github.com/apache/solr/pull/1578 https://issues.apache.org/jira/browse/SOLR-16756 # Description The getKnnVectorsFormatForField() override in SchemaCodecFactory doesn't seem to be covered by any of the existing

[jira] [Comment Edited] (SOLR-16741) CLUSTERSTATUS API returns wrong value for state ,leader for PRS collections

2023-04-20 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714464#comment-17714464 ] Ishan Chattopadhyaya edited comment on SOLR-16741 at 4/20/23 2:17 PM: -

[jira] [Created] (SOLR-16756) SchemaCodecFactory: add test coverage for getKnnVectorsFormatForField

2023-04-20 Thread Leonardo Potenza (Jira)
Leonardo Potenza created SOLR-16756: --- Summary: SchemaCodecFactory: add test coverage for getKnnVectorsFormatForField Key: SOLR-16756 URL: https://issues.apache.org/jira/browse/SOLR-16756 Project: So

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1172586018 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -204,6 +206,8 @@ static class AffinityPlacementPlugin imple

[GitHub] [solr] risdenk commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-20 Thread via GitHub
risdenk commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1172585833 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -204,6 +206,8 @@ static class AffinityPlacementPlugin implements Plac

[jira] [Commented] (SOLR-16741) CLUSTERSTATUS API returns wrong value for state ,leader for PRS collections

2023-04-20 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714464#comment-17714464 ] Ishan Chattopadhyaya commented on SOLR-16741: - +1 to include in 9.2.1, if @ju

[GitHub] [solr-operator] smoldenhauer-ish commented on issue #537: Slow restart of Solr Pod init_container cp-solr-xml chown

2023-04-20 Thread via GitHub
smoldenhauer-ish commented on issue #537: URL: https://github.com/apache/solr-operator/issues/537#issuecomment-1515829269 I saw that [fsGroupChangePolicy](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#configure-volume-permission-and-ownership-change-policy-for-po