magibney commented on PR #1440: URL: https://github.com/apache/solr/pull/1440#issuecomment-1516725785
@noblepaul take a look at https://github.com/apache/solr/pull/513 -- in particular, the RawShimTextResponseWriter which together with TextResponseWriter (from which it is invoked) actually handles flipping raw transformer fields over such that `TextWriter.writeStrRaw()` will be called. I think you need an analogous multiplexing (flipping between raw and non-raw) somewhere in JsonResponseWriter. Again it's possible that any concrete performance improvement might be largely a consequence of avoiding [this](https://github.com/apache/solr/blob/c99af207c761ec34812ef1cc3054eb2804b7448b/solr/core/src/java/org/apache/solr/response/QueryResponseWriterUtil.java#L51-L73), which IMO looks really really wrong, and would be the first thing I'd change, even if pursuing using Jackson for JSON serialization anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
