[jira] [Commented] (SOLR-16573) SolrClientTestRule for EmbeddedSolrServer

2023-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686874#comment-17686874 ] ASF subversion and git services commented on SOLR-16573: Commit 7

[GitHub] [solr] dsmiley merged pull request #1347: SOLR-16573: Fix test Windows path separator

2023-02-09 Thread via GitHub
dsmiley merged PR #1347: URL: https://github.com/apache/solr/pull/1347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] dsmiley opened a new pull request, #1347: SOLR-16573: Fix test Windows path separator

2023-02-09 Thread via GitHub
dsmiley opened a new pull request, #1347: URL: https://github.com/apache/solr/pull/1347 https://issues.apache.org/jira/browse/SOLR-16573 Fixing an oversight of mine in the configSet reference that can be a path and thus might be platform specific. Later I want to move this sort

[jira] [Comment Edited] (SOLR-16441) Upgrade Jetty to 11.x

2023-02-09 Thread Vinod Singh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686864#comment-17686864 ] Vinod Singh edited comment on SOLR-16441 at 2/10/23 4:21 AM: -

[jira] [Commented] (SOLR-16441) Upgrade Jetty to 11.x

2023-02-09 Thread Vinod Singh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686864#comment-17686864 ] Vinod Singh commented on SOLR-16441: [Spring Boot 3|https://github.com/spring-projec

[jira] [Commented] (SOLR-16554) Update docs on filter cache

2023-02-09 Thread Andy Lester (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686778#comment-17686778 ] Andy Lester commented on SOLR-16554: Thanks for the interest. I forgot I had this ope

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686753#comment-17686753 ] Eric Pugh commented on SOLR-16563: -- I'd love to see a first draft! > Http2SolrClient sh

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686746#comment-17686746 ] David Smiley commented on SOLR-16563: - I looked hard but can't find a recent proposal

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686718#comment-17686718 ] Jan Høydahl commented on SOLR-16563: The QueryRequest stull is more long term since i

[GitHub] [solr] janhoy commented on pull request #1346: SOLR-16457 Add symbolic link version of solr.install.dir to security.policy

2023-02-09 Thread via GitHub
janhoy commented on PR #1346: URL: https://github.com/apache/solr/pull/1346#issuecomment-1424675324 Found a bug while testing. Need to resolve `pwd -L` on the original script path, not on the already normalized physical `SOLR_TIP`. After fixing that it woks. I tested with: ```bash

[jira] [Resolved] (SOLR-16628) Occasional resource leak around XmlConfigFile parsing

2023-02-09 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney resolved SOLR-16628. --- Fix Version/s: 9.2 Assignee: Michael Gibney Resolution: Fixed > Occasional re

[jira] [Commented] (SOLR-16628) Occasional resource leak around XmlConfigFile parsing

2023-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686707#comment-17686707 ] ASF subversion and git services commented on SOLR-16628: Commit a

[jira] [Commented] (SOLR-16628) Occasional resource leak around XmlConfigFile parsing

2023-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686706#comment-17686706 ] ASF subversion and git services commented on SOLR-16628: Commit e

[GitHub] [solr] magibney merged pull request #1302: SOLR-16628: Ensure that InputStreams are closed after Xml parsing

2023-02-09 Thread via GitHub
magibney merged PR #1302: URL: https://github.com/apache/solr/pull/1302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686700#comment-17686700 ] Eric Pugh commented on SOLR-16563: -- [~janhoy] do you think that as part of THIS jira we

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686693#comment-17686693 ] Jan Høydahl commented on SOLR-16563: I'm OK with nuking defaultCollection. If anywher

[GitHub] [solr] risdenk commented on a diff in pull request #1346: SOLR-16457 Add symbolic link version of solr.install.dir to security.policy

2023-02-09 Thread via GitHub
risdenk commented on code in PR #1346: URL: https://github.com/apache/solr/pull/1346#discussion_r1101861421 ## solr/bin/solr.cmd: ## @@ -1397,15 +1397,15 @@ IF "%FG%"=="1" ( "%JAVA%" %SERVEROPT% %SOLR_JAVA_MEM% %START_OPTS% ^ -Dlog4j.configurationFile="%LOG4J_CONFIG%" -D

[jira] [Commented] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2023-02-09 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686691#comment-17686691 ] Jan Høydahl commented on SOLR-16457: I know, but it will be a temporary fix and has p

[GitHub] [solr] janhoy opened a new pull request, #1346: SOLR-16457 Add symbolic link version of solr.install.dir to security.policy

2023-02-09 Thread via GitHub
janhoy opened a new pull request, #1346: URL: https://github.com/apache/solr/pull/1346 I.e. typically til will allow /opt/solr/... in addition to /opt/solr-X.Y.Z/... I file this PR on https://issues.apache.org/jira/browse/SOLR-16457 since it is related and still un-released. --

[jira] [Commented] (SOLR-16573) SolrClientTestRule for EmbeddedSolrServer

2023-02-09 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686680#comment-17686680 ] Kevin Risden commented on SOLR-16573: - I think this commit is potentially causing iss

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686659#comment-17686659 ] Jason Gerlowski commented on SOLR-16563: (Thanks David - INFRA-24180 created.) >

[jira] [Comment Edited] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686649#comment-17686649 ] David Smiley edited comment on SOLR-16563 at 2/9/23 4:59 PM: -

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686649#comment-17686649 ] David Smiley commented on SOLR-16563: - This is a request to INFRA.  See INFRA-23707 a

[jira] [Reopened] (SOLR-16636) ZkStateReader.waitForState should not register a watch if state already matches predicate

2023-02-09 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya reopened SOLR-16636: - > ZkStateReader.waitForState should not register a watch if state already > matches

[jira] [Comment Edited] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686642#comment-17686642 ] Jason Gerlowski edited comment on SOLR-16563 at 2/9/23 4:44 PM: ---

[jira] [Comment Edited] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686642#comment-17686642 ] Jason Gerlowski edited comment on SOLR-16563 at 2/9/23 4:43 PM: ---

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686642#comment-17686642 ] Jason Gerlowski commented on SOLR-16563: (I missed this at the time because Eric

[jira] [Commented] (SOLR-16558) Add Group parameter support for JSON Request API

2023-02-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686617#comment-17686617 ] Jason Gerlowski commented on SOLR-16558: I'd also love to see the JSON Request sy

[jira] [Commented] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2023-02-09 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686608#comment-17686608 ] Kevin Risden commented on SOLR-16457: - A workaround might be to use jdk.io.permission

[jira] [Comment Edited] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2023-02-09 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686604#comment-17686604 ] Kevin Risden edited comment on SOLR-16457 at 2/9/23 3:38 PM: -

[jira] [Commented] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2023-02-09 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686604#comment-17686604 ] Kevin Risden commented on SOLR-16457: - O interesting - https://mail.openjdk.org/pipe

[GitHub] [solr] tylerbertrand opened a new pull request, #1345: Gradle: Use lazy file types

2023-02-09 Thread via GitHub
tylerbertrand opened a new pull request, #1345: URL: https://github.com/apache/solr/pull/1345 # Description Updated inputs defined in `CommandLineArgumentProvider`s to use lazy file types. While usage of "eager" file types is not currently causing issues, i

[GitHub] [solr] risdenk opened a new pull request, #1344: Tracking Field usage with DirectoryReader

2023-02-09 Thread via GitHub
risdenk opened a new pull request, #1344: URL: https://github.com/apache/solr/pull/1344 https://issues.apache.org/jira/browse/SOLR-X -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Commented] (SOLR-16554) Update docs on filter cache

2023-02-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686584#comment-17686584 ] Jason Gerlowski commented on SOLR-16554: bq. This is something I'm willing to tak

[GitHub] [solr] epugh commented on pull request #1014: Refactor SolrZkclient to use a Builder pattern

2023-02-09 Thread via GitHub
epugh commented on PR #1014: URL: https://github.com/apache/solr/pull/1014#issuecomment-1424338918 Could we follow the same pattern defined in SOLR-16595 and SOLR-16590 of using `with` instead of bare property names, and using `TimeUnit`? Have some consistency in how we create our builder

[GitHub] [solr] epugh commented on pull request #1338: SOLR-16595: Standardize Solr Client Builders handling of times

2023-02-09 Thread via GitHub
epugh commented on PR #1338: URL: https://github.com/apache/solr/pull/1338#issuecomment-1424332956 I broke the ConncurrentUpdateSolrClient unit test.. sigh First pass thorugh, no luck on why setting the timeout isn't working. -- This is an automated message from the Apache Git Ser

[jira] [Commented] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2023-02-09 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686484#comment-17686484 ] Jan Høydahl commented on SOLR-16457: There was a change in JDK9 in how FilePermission

[GitHub] [solr] janhoy commented on pull request #1342: SOLR-16650, SOLR-16532: OTEL tracer additional tags

2023-02-09 Thread via GitHub
janhoy commented on PR #1342: URL: https://github.com/apache/solr/pull/1342#issuecomment-1424094122 Removed the `net.*` tags, and instead added a static `host.name` tag with solr's host name (as defined in `host` sysprop). All changes are now in OTEL module only so no need for extra CHANGES

[GitHub] [solr] janhoy commented on a diff in pull request #1342: SOLR-16650, SOLR-16532: OTEL tracer additional tags

2023-02-09 Thread via GitHub
janhoy commented on code in PR #1342: URL: https://github.com/apache/solr/pull/1342#discussion_r1101340577 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -310,7 +310,11 @@ protected static Span buildSpan(Tracer tracer, HttpServletRequest request) {

[GitHub] [solr] janhoy commented on a diff in pull request #1342: SOLR-16650, SOLR-16532: OTEL tracer additional tags

2023-02-09 Thread via GitHub
janhoy commented on code in PR #1342: URL: https://github.com/apache/solr/pull/1342#discussion_r1101290759 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -310,7 +310,11 @@ protected static Span buildSpan(Tracer tracer, HttpServletRequest request) {

[GitHub] [solr] janhoy commented on pull request #1342: SOLR-16650, SOLR-16532: OTEL tracer additional tags

2023-02-09 Thread via GitHub
janhoy commented on PR #1342: URL: https://github.com/apache/solr/pull/1342#issuecomment-1423997100 > > Not adding CHANGES line since none of this is yet released. > > But this change isn't restricted to OTEL; any tracer plugin would get these new tags. Any way, it's fine with me.