janhoy commented on code in PR #1342:
URL: https://github.com/apache/solr/pull/1342#discussion_r1101340577
##########
solr/core/src/java/org/apache/solr/servlet/ServletUtils.java:
##########
@@ -310,7 +310,11 @@ protected static Span buildSpan(Tracer tracer,
HttpServletRequest request) {
.asChildOf(tracer.extract(Format.Builtin.HTTP_HEADERS, new
HttpServletCarrier(request)))
.withTag(Tags.SPAN_KIND, Tags.SPAN_KIND_SERVER)
.withTag(Tags.HTTP_METHOD, request.getMethod())
- .withTag(Tags.HTTP_URL, request.getRequestURL().toString());
+ .withTag(Tags.HTTP_URL, request.getRequestURL().toString())
+ .withTag("net.host.name", request.getServerName())
+ .withTag("net.host.port", request.getServerPort())
+ .withTag("net.peer.name", request.getRemoteHost())
+ .withTag("net.peer.port", request.getRemotePort());
Review Comment:
Hmm, I wonder if I'll skip these four tags in this PR, and just do the
refGuide change to keep it contained.
What I initially planned was to add the solr host name in the trace, not the
http request host name (which could be an alias, and is also part of the URL).
It could be possible to add the `host.name` tag in a static way as part of the
Otel configurator and avoid touching this common part for now.
Once we replace OT instrumentation with OTEL instrumentation, we can revisit
what tags to set by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
