epugh commented on PR #1014: URL: https://github.com/apache/solr/pull/1014#issuecomment-1424338918
Could we follow the same pattern defined in SOLR-16595 and SOLR-16590 of using `with` instead of bare property names, and using `TimeUnit`? Have some consistency in how we create our builders! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org