stillalex commented on PR #1332:
URL: https://github.com/apache/solr/pull/1332#issuecomment-1416495408
@gerlowskija if you have some time, please take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
stillalex opened a new pull request, #1332:
URL: https://github.com/apache/solr/pull/1332
https://issues.apache.org/jira/browse/SOLR-16393
# Description
Alias apis
# Solution
Please provide a short description of the approach taken to implement your
gabrielmagno commented on PR #1331:
URL: https://github.com/apache/solr/pull/1331#issuecomment-1416440411
Fixed. `gradlew check` seems to be running fine now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
gabrielmagno commented on PR #1331:
URL: https://github.com/apache/solr/pull/1331#issuecomment-1416400727
> @gabrielmagno looks like its related to your change. `./gradlew tidy` may
fix it. I see in
`[solr/core/src/java/org/apache/solr/search/ValueSourceParser.java](https://github.com/apach
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096268870
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/json/DirectJsonQueryRequestFacetingEmbeddedTest.java:
##
@@ -38,7 +39,6 @@
@SuppressSSL
public class DirectJs
risdenk commented on PR #1331:
URL: https://github.com/apache/solr/pull/1331#issuecomment-1416375388
@gabrielmagno looks like its related to your change. `./gradlew tidy` may
fix it. I see in
`[solr/core/src/java/org/apache/solr/search/ValueSourceParser.java](https://github.com/apache/solr/
gabrielmagno commented on PR #1331:
URL: https://github.com/apache/solr/pull/1331#issuecomment-1416369277
I tried running `./gradlew check`, but I got an error that I'm not sure if
it is related to my changes or is a bug from upstream master:
```
* What went wrong:
Execution failed
gabrielmagno opened a new pull request, #1331:
URL: https://github.com/apache/solr/pull/1331
https://issues.apache.org/jira/browse/SOLR-16646
# Description
We created a new function query operator called `isnan`, that checks rather
a value is a float NaN (not a number).
[
https://issues.apache.org/jira/browse/SOLR-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabriel Magno updated SOLR-16646:
-
Description:
It would be useful to have a function query operator (e.g. `isnan`) to check
rather
Gabriel Magno created SOLR-16646:
Summary: Create a new function query operator to verify if value
is NaN (isnan)
Key: SOLR-16646
URL: https://issues.apache.org/jira/browse/SOLR-16646
Project: Solr
dsmiley commented on code in PR #1330:
URL: https://github.com/apache/solr/pull/1330#discussion_r1096112932
##
solr/CHANGES.txt:
##
@@ -51,6 +51,8 @@ New Features
* SOLR-16596: Learning To Rank - Added support for null feature values in
multiple additive trees models (Anna R
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096112550
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096112550
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096105477
##
solr/bin/solr:
##
@@ -2312,13 +2341,13 @@ function start_solr() {
echo ""
fi
# no lsof on cygwin though
-if lsof -v 2>&1 | grep -q revision; then
madrob commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096105999
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool()
madrob commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096095124
##
solr/bin/solr:
##
@@ -2312,13 +2341,13 @@ function start_solr() {
echo ""
fi
# no lsof on cygwin though
-if lsof -v 2>&1 | grep -q revision; then
+
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096105477
##
solr/bin/solr:
##
@@ -2312,13 +2341,13 @@ function start_solr() {
echo ""
fi
# no lsof on cygwin though
-if lsof -v 2>&1 | grep -q revision; then
[
https://issues.apache.org/jira/browse/SOLR-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-9698:
---
Status: Patch Available (was: Open)
> Fix bin/solr script calculations - start/stop wait time and RMI
Paul-Blanchaert commented on PR #1325:
URL: https://github.com/apache/solr/pull/1325#issuecomment-1416224562
I gave it a try...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096103320
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
magibney commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096098937
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
risdenk commented on code in PR #1330:
URL: https://github.com/apache/solr/pull/1330#discussion_r1096097098
##
solr/CHANGES.txt:
##
@@ -51,6 +51,8 @@ New Features
* SOLR-16596: Learning To Rank - Added support for null feature values in
multiple additive trees models (Anna R
madrob commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096095124
##
solr/bin/solr:
##
@@ -2312,13 +2341,13 @@ function start_solr() {
echo ""
fi
# no lsof on cygwin though
-if lsof -v 2>&1 | grep -q revision; then
+
dsmiley commented on code in PR #1330:
URL: https://github.com/apache/solr/pull/1330#discussion_r1096094877
##
solr/CHANGES.txt:
##
@@ -51,6 +51,8 @@ New Features
* SOLR-16596: Learning To Rank - Added support for null feature values in
multiple additive trees models (Anna R
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096093955
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
[
https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683969#comment-17683969
]
Kevin Risden commented on SOLR-15955:
-
PR for changes and upgrade notes - https://git
[
https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-15955:
Status: Patch Available (was: Reopened)
> Update Jetty dependency to 10
>
risdenk commented on code in PR #1330:
URL: https://github.com/apache/solr/pull/1330#discussion_r1096071702
##
solr/CHANGES.txt:
##
@@ -51,6 +51,8 @@ New Features
* SOLR-16596: Learning To Rank - Added support for null feature values in
multiple additive trees models (Anna R
risdenk opened a new pull request, #1330:
URL: https://github.com/apache/solr/pull/1330
https://issues.apache.org/jira/browse/SOLR-15955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
magibney commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096052115
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096021700
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
Colvin Cowie created SOLR-16645:
---
Summary: Support ss and netstat as alternatives to lsof
Key: SOLR-16645
URL: https://issues.apache.org/jira/browse/SOLR-16645
Project: Solr
Issue Type: Improve
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096021700
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
magibney commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096019115
##
solr/bin/solr:
##
@@ -2312,13 +2341,13 @@ function start_solr() {
echo ""
fi
# no lsof on cygwin though
-if lsof -v 2>&1 | grep -q revision; then
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096011334
##
solr/bin/solr:
##
@@ -2312,13 +2341,13 @@ function start_solr() {
echo ""
fi
# no lsof on cygwin though
-if lsof -v 2>&1 | grep -q revision; then
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096011334
##
solr/bin/solr:
##
@@ -2312,13 +2341,13 @@ function start_solr() {
echo ""
fi
# no lsof on cygwin though
-if lsof -v 2>&1 | grep -q revision; then
stillalex commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1416106834
thank you @epugh!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
magibney commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1095995278
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1095968781
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
[
https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683932#comment-17683932
]
Kevin Risden commented on SOLR-15955:
-
[~janhoy] I think I need to add CHANGES.txt an
[
https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colvin Cowie updated SOLR-16641:
Summary: Circular task dependency in localSettings (Generate
gradle.properties from gradlew) (was:
[
https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683929#comment-17683929
]
Eric Pugh commented on SOLR-16556:
--
[~mnrathod] thanks for pinging me.
I managed to
[
https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683927#comment-17683927
]
Jan Høydahl commented on SOLR-15955:
Looks like jetty is 10.0.13 in main now, can thi
janhoy commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1416039622
Please add a line to `CHANGES.txt` for 9.2 release. It can be useful for
folks to get alerted about this change.
--
This is an automated message from the Apache Git Service.
To respond to t
magibney commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1095906127
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
andywebb1975 commented on code in PR #1324:
URL: https://github.com/apache/solr/pull/1324#discussion_r1095911296
##
solr/core/src/java/org/apache/solr/search/ReRankQParserPlugin.java:
##
@@ -72,25 +74,33 @@ public Query parse() throws SyntaxError {
double reRankWeight =
andywebb1975 commented on code in PR #1324:
URL: https://github.com/apache/solr/pull/1324#discussion_r1095910424
##
solr/core/src/java/org/apache/solr/search/ReRankQParserPlugin.java:
##
@@ -99,6 +109,7 @@ protected float combine(
private static final class ReRankQuery extend
colvinco commented on code in PR #1329:
URL: https://github.com/apache/solr/pull/1329#discussion_r1095907702
##
solr/bin/solr.cmd:
##
@@ -1409,11 +1428,15 @@ IF "%FG%"=="1" (
-Djava.io.tmpdir="%SOLR_SERVER_DIR%\tmp" -jar start.jar
%SOLR_JETTY_CONFIG% "%SOLR_JETTY_ADDL_CONF
colvinco opened a new pull request, #1329:
URL: https://github.com/apache/solr/pull/1329
https://issues.apache.org/jira/browse/SOLR-9698
# Description
This is a set of fixes for the Windows solr.cmd script.
- `SOLR_STOP_WAIT` and `SOLR_START_WAIT` are now respect
[
https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16618.
--
Fix Version/s: main (10.0)
9.2
Resolution: Fixed
> Admin UI Analysis page sho
[
https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683899#comment-17683899
]
Eric Pugh commented on SOLR-16618:
--
If the Admin UI breaks on some really big schemas, l
[
https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683898#comment-17683898
]
ASF subversion and git services commented on SOLR-16618:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683897#comment-17683897
]
ASF subversion and git services commented on SOLR-16618:
Commit e
epugh merged PR #1304:
URL: https://github.com/apache/solr/pull/1304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh merged PR #1327:
URL: https://github.com/apache/solr/pull/1327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy merged PR #1326:
URL: https://github.com/apache/solr/pull/1326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on PR #1326:
URL: https://github.com/apache/solr/pull/1326#issuecomment-1415948182
Thanks. Fingers crossed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1095862039
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
elyograg commented on PR #1328:
URL: https://github.com/apache/solr/pull/1328#issuecomment-1415878965
ss is probably more likely to have the same options on multiple platforms
than netstat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1095682367
##
buildSrc/src/main/java/org/apache/lucene/gradle/GradlePropertiesGenerator.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1095678062
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1095676844
##
solr/bin/solr:
##
@@ -2158,6 +2158,35 @@ function mk_writable_dir() {
fi
}
+# Check whether at least one of lsof/netstat/ss are available
+function get_port_tool
colvinco opened a new pull request, #1328:
URL: https://github.com/apache/solr/pull/1328
https://issues.apache.org/jira/browse/SOLR-X
# Description
The current start command requires `lsof` to be available. If you don't have
`lsof` it does a hardcoded 10 second
cpoerschke commented on code in PR #1324:
URL: https://github.com/apache/solr/pull/1324#discussion_r1095579544
##
solr/core/src/java/org/apache/solr/search/ReRankQParserPlugin.java:
##
@@ -72,25 +74,33 @@ public Query parse() throws SyntaxError {
double reRankWeight = l
Ishan Chattopadhyaya created SOLR-16644:
---
Summary: Entropy warning thresholds need to be revisited
Key: SOLR-16644
URL: https://issues.apache.org/jira/browse/SOLR-16644
Project: Solr
Is
muffl0n opened a new pull request, #1327:
URL: https://github.com/apache/solr/pull/1327
# Description
Configuration keys were mixed up making it hard to find them in the
documentation and even harder to debug timeouts on backup.
# Solution
Fixed the documentation.
[
https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683724#comment-17683724
]
Maulin commented on SOLR-16556:
---
Hi [~epugh] Could you please have a look at this? Please
67 matches
Mail list logo
