[
https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683929#comment-17683929
]
Eric Pugh commented on SOLR-16556:
----------------------------------
[~mnrathod] thanks for pinging me.
I managed to get [~gabrielmagno] to look at your patch with me, to give another
perspective. I don't have [~jbernste] deep understanding of the core
principles under pinning the streaming expressions, so I'm a bit out of my
depth.
Here are some thoughts on maybe how to move forward with this contribution to
get it committed.
1) [~gabrielmagno] pointed out that this really feels like a "slice" operator
versus a "paging" operator. In my mind, the word "paging" is really about the
concept that I'll iteratively work through the data set by updating my start
parameter over time and is very search world specific. What I see is
something that can create a sub set of tuples from any source... Could be a
search, but it could also be from a CSV file! What do you think about
renaming this to "slice" instead?
2) I like the simplicity of the operators over the interesting approach Joel
provided. It's cool we can use the recnum() feature, but it's definitely more
complex approach!
3) Have you done any performance testing of combining this operator, call it
"slice", with a "sort" operator, which might simplify this code base? We
looked a little bit to try and understand if you did a slice, and wrapped it
with a sort, would you get the same thing? Just trying to think about if this
would simplify the logic conceptually a bit? Something like
sort(slice(expression, start, rows), by="fields").
> Solr stream expression: Implement Page Streaming Decorator to allow results
> to be displayed with pagination.
> ------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-16556
> URL: https://issues.apache.org/jira/browse/SOLR-16556
> Project: Solr
> Issue Type: Improvement
> Components: streaming expressions
> Reporter: Maulin
> Priority: Major
> Labels: Streamingexpression, decorator, paging
> Attachments: Page Decorator Performance Reading.xlsx
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Solr stream expression: Implement Page Streaming Decorator to allow results
> to be displayed with pagination.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
