colvinco commented on code in PR #1328:
URL: https://github.com/apache/solr/pull/1328#discussion_r1096011334
##########
solr/bin/solr:
##########
@@ -2312,13 +2341,13 @@ function start_solr() {
echo ""
fi
# no lsof on cygwin though
- if lsof -v 2>&1 | grep -q revision; then
+ if [ -n "$(get_port_tool)" ]; then
echo -n "Waiting up to $SOLR_START_WAIT seconds to see Solr running on
port $SOLR_PORT"
# Launch in a subshell to show the spinner
(loops=0
while true
do
- running=$(lsof -t -PniTCP:$SOLR_PORT -sTCP:LISTEN || :)
+ running=$(check_port_in_use $SOLR_PORT)
Review Comment:
I must admit I can't see that it would have had any effect here. But I may
be coming it at from the wrong angle. I see it was originally added by @madrob
https://github.com/apache/solr/commit/3ed17c2737db038c2908a1475099647fb4ef5b38
If I create a script:
```
echo hello
exit 1
```
And call it with ` || :` the stdout still gets captured. The exit code will
be 0 rather than 1, but I don't think that's adding anything here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
