sonatype-lift[bot] commented on code in PR #1266:
URL: https://github.com/apache/solr/pull/1266#discussion_r1060327540
##
solr/core/src/java/org/apache/solr/search/facet/FacetModule.java:
##
@@ -380,26 +400,24 @@ public Object getMergedResult() {
return getDouble();
noblepaul commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1060317489
##
solr/core/src/test-files/solr/solr.xml:
##
@@ -35,11 +35,6 @@
${connTimeout:15000}
-
Review Comment:
As we are making `SolrCores` pluggable, we need
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653826#comment-17653826
]
Ishan Chattopadhyaya commented on SOLR-16531:
-
bq. On a maybe related note, t
noblepaul commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1060317489
##
solr/core/src/test-files/solr/solr.xml:
##
@@ -35,11 +35,6 @@
${connTimeout:15000}
-
Review Comment:
As we are making `SolrCores` pluggable, we need
vatsalpatel3689 closed pull request #1266: Solr fkltr 9 1
URL: https://github.com/apache/solr/pull/1266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vatsalpatel3689 opened a new pull request, #1266:
URL: https://github.com/apache/solr/pull/1266
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
vatsalpatel3689 closed pull request #1263: diff with 9_1
URL: https://github.com/apache/solr/pull/1263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: i
vatsalpatel3689 closed pull request #1264: Branch 9 1 neo
URL: https://github.com/apache/solr/pull/1264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1060284411
##
solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
[
https://issues.apache.org/jira/browse/SOLR-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653734#comment-17653734
]
Shawn Heisey commented on SOLR-16605:
-
I have not been able to figure out what is hap
dsmiley commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060216195
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -2283,6 +2292,26 @@ protected CloudSolrClient getCommonCloudSolrClient() {
dsmiley commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060214019
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -147,6 +147,8 @@ public void beforeTest() {
protected volatile ChaosMonk
justinrsweeney commented on code in PR #1258:
URL: https://github.com/apache/solr/pull/1258#discussion_r1060209357
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -679,7 +679,13 @@ private void constructState(Set
changedCollections) {
sonatype-lift[bot] commented on code in PR #1264:
URL: https://github.com/apache/solr/pull/1264#discussion_r1060207647
##
solr/core/build.gradle:
##
@@ -15,21 +15,34 @@
* limitations under the License.
*/
-
apply plugin: 'java-library'
description = 'Apache Solr Core'
sonatype-lift[bot] commented on code in PR #1263:
URL: https://github.com/apache/solr/pull/1263#discussion_r1060206704
##
dev-tools/scripts/cherrypick.sh:
##
@@ -0,0 +1,215 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor licen
sonatype-lift[bot] commented on code in PR #1263:
URL: https://github.com/apache/solr/pull/1263#discussion_r106020
##
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##
@@ -,7 +2357,9 @@ protected Long
seedBucketsWithHighestVersion(SolrIndexSearcher newSearche
sonatype-lift[bot] commented on code in PR #1263:
URL: https://github.com/apache/solr/pull/1263#discussion_r1060206625
##
solr/core/src/java/org/apache/solr/security/MultiAuthPlugin.java:
##
@@ -185,7 +210,8 @@ public boolean doAuthenticate(HttpServletRequest request,
HttpServl
sonatype-lift[bot] commented on code in PR #1263:
URL: https://github.com/apache/solr/pull/1263#discussion_r1060206585
##
solr/core/src/java/org/apache/solr/schema/EnumFieldType.java:
##
@@ -45,19 +44,23 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- * Fi
sonatype-lift[bot] commented on code in PR #1263:
URL: https://github.com/apache/solr/pull/1263#discussion_r1060206538
##
solr/core/src/java/org/apache/solr/handler/admin/ZookeeperStatusHandler.java:
##
@@ -292,42 +333,62 @@ protected List getZkRawResponse(String
zkHostPort, St
sonatype-lift[bot] commented on code in PR #1263:
URL: https://github.com/apache/solr/pull/1263#discussion_r1060206517
##
solr/core/build.gradle:
##
@@ -59,38 +100,50 @@ dependencies {
implementation "org.apache.lucene:lucene-spatial-extras"
implementation "org.apache.luce
epugh opened a new pull request, #1265:
URL: https://github.com/apache/solr/pull/1265
https://issues.apache.org/jira/browse/SOLR-16606
# Description
Test was filtered out due to bug, but it is now fixed.
# Solution
restore test
--
This is an automated me
janhoy commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1060205004
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/OtelTracerConfiguratorTest.java:
##
@@ -73,4 +86,24 @@ public void testSetDefaultIfNotConfigured() {
sonatype-lift[bot] commented on code in PR #1262:
URL: https://github.com/apache/solr/pull/1262#discussion_r1060204662
##
solr/core/src/java/org/apache/solr/search/facet/FacetModule.java:
##
@@ -409,14 +409,14 @@ public static int compare(double a, double b,
FacetRequest.SortDi
epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060204376
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -965,11 +964,12 @@ public void testRetryUpdatesWhenClusterStateIsStale()
throw
epugh commented on PR #1256:
URL: https://github.com/apache/solr/pull/1256#issuecomment-1369252897
@dsmiley there are 45 more tests that I need to fix. I wanted to just
check in that the way I am migrating the tests makes sense to you?
--
This is an automated message from the Apache
epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060204103
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -1990,13 +1990,22 @@ protected void destroyServers() throws Exception {
sonatype-lift[bot] commented on code in PR #1264:
URL: https://github.com/apache/solr/pull/1264#discussion_r1060204105
##
cluster/scripts/deleteAndReAddNodes.sh:
##
@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+
+endpoint=$1
+collection=$2
+shard=$3
+replicaType=$4
+nodesFileName=$5
+b
epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060204038
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -1990,13 +1990,22 @@ protected void destroyServers() throws Exception {
epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060203879
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -147,6 +147,8 @@ public void beforeTest() {
protected volatile ChaosMonkey
epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060203789
##
solr/modules/hdfs/src/test/org/apache/solr/hdfs/cloud/HdfsRecoveryZkTest.java:
##
@@ -29,7 +28,6 @@
import org.junit.BeforeClass;
@Nightly
-@LuceneTestCase.AwaitsFix(
Eric Pugh created SOLR-16606:
Summary: Restore running HdfsRecoveryZkTest.java
Key: SOLR-16606
URL: https://issues.apache.org/jira/browse/SOLR-16606
Project: Solr
Issue Type: Bug
Security L
sonatype-lift[bot] commented on code in PR #1261:
URL: https://github.com/apache/solr/pull/1261#discussion_r1060203693
##
solr/core/src/java/org/apache/solr/search/facet/FacetModule.java:
##
@@ -16,13 +16,14 @@
*/
package org.apache.solr.search.facet;
+import static org.apa
epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060203187
##
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##
@@ -2669,6 +2669,18 @@ public static CloudSolrClient getCloudSolrClient(String
zkHost) {
.b
sonatype-lift[bot] commented on code in PR #1261:
URL: https://github.com/apache/solr/pull/1261#discussion_r1060202487
##
dev-tools/scripts/cherrypick.sh:
##
@@ -0,0 +1,214 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor licen
dsmiley commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1060202102
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/OtelTracerConfiguratorTest.java:
##
@@ -73,4 +86,24 @@ public void testSetDefaultIfNotConfigured() {
dsmiley commented on PR #1252:
URL: https://github.com/apache/solr/pull/1252#issuecomment-1369247648
> So I'm not a fan of putting non Solr direct dependencies in versions.props
- basically they will never get removed. We should be upgrading the libraries
that use this transitive dependency
janhoy commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1060199981
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/OtelTracerConfiguratorTest.java:
##
@@ -73,4 +86,24 @@ public void testSetDefaultIfNotConfigured() {
vatsalpatel3689 opened a new pull request, #1264:
URL: https://github.com/apache/solr/pull/1264
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
risdenk commented on PR #1252:
URL: https://github.com/apache/solr/pull/1252#issuecomment-1369240914
So I'm not a fan of putting non Solr direct dependencies in versions.props -
basically they will never get removed. We should be upgrading the libraries
that use this transitive dependency -
dsmiley commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060175270
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -965,11 +964,12 @@ public void testRetryUpdatesWhenClusterStateIsStale()
thr
vatsalpatel3689 opened a new pull request, #1263:
URL: https://github.com/apache/solr/pull/1263
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
vatsalpatel3689 closed pull request #1261: MN-551 | working and tested changes
of solr 9.1
URL: https://github.com/apache/solr/pull/1261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vatsalpatel3689 closed pull request #1262: working and tested changes of solr
9.1
URL: https://github.com/apache/solr/pull/1262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
vatsalpatel3689 opened a new pull request, #1262:
URL: https://github.com/apache/solr/pull/1262
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
vatsalpatel3689 opened a new pull request, #1261:
URL: https://github.com/apache/solr/pull/1261
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
[
https://issues.apache.org/jira/browse/SOLR-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653696#comment-17653696
]
Shawn Heisey commented on SOLR-16605:
-
The committed change fixes the percentage calc
[
https://issues.apache.org/jira/browse/SOLR-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653694#comment-17653694
]
ASF subversion and git services commented on SOLR-16605:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653693#comment-17653693
]
ASF subversion and git services commented on SOLR-16605:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653691#comment-17653691
]
Shawn Heisey commented on SOLR-16605:
-
Switching to UnixOperatingSystemMXBean in my t
[
https://issues.apache.org/jira/browse/SOLR-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653690#comment-17653690
]
Shawn Heisey commented on SOLR-16605:
-
Test program:
{code:java}
package org.elyograg
[
https://issues.apache.org/jira/browse/SOLR-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653689#comment-17653689
]
Shawn Heisey commented on SOLR-16605:
-
If I just do the javascript change, that seems
dsmiley commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060173672
##
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##
@@ -2669,6 +2669,18 @@ public static CloudSolrClient getCloudSolrClient(String
zkHost) {
Shawn Heisey created SOLR-16605:
---
Summary: CPU in UI cloud->nodes is always 0%, even when Solr is
very busy.
Key: SOLR-16605
URL: https://issues.apache.org/jira/browse/SOLR-16605
Project: Solr
sonatype-lift[bot] commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060167988
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -2283,6 +2292,26 @@ protected CloudSolrClient getCommonCloudSolr
[
https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653662#comment-17653662
]
Henri Biestro commented on SOLR-646:
14+ years between creation and resolution (as a wo
epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060127703
##
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##
@@ -2669,6 +2669,18 @@ public static CloudSolrClient getCloudSolrClient(String
zkHost) {
.b
[
https://issues.apache.org/jira/browse/SOLR-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653655#comment-17653655
]
Eric Pugh commented on SOLR-16604:
--
This could be a place for us to dig more into using
Eric Pugh created SOLR-16604:
Summary: Use Builders directly in tests instead of delegating to
SolrTestCaseJ4
Key: SOLR-16604
URL: https://issues.apache.org/jira/browse/SOLR-16604
Project: Solr
epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060102824
##
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##
@@ -2669,6 +2669,18 @@ public static CloudSolrClient getCloudSolrClient(String
zkHost) {
.b
dsmiley commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060094911
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -257,6 +259,12 @@ public Builder setRetryExpiryTime(int secs) {
return thi
[
https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653634#comment-17653634
]
David Smiley commented on SOLR-10466:
-
bq. it basically feels like actually more of
dsmiley commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1060089112
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/OtelTracerConfiguratorTest.java:
##
@@ -73,4 +86,24 @@ public void testSetDefaultIfNotConfigured() {
[
https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653632#comment-17653632
]
Jan Høydahl commented on SOLR-10466:
I feel quilty for adding this way back, but it w
dsmiley commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1060083238
##
solr/core/src/test-files/solr/solr.xml:
##
@@ -35,11 +35,6 @@
${connTimeout:15000}
-
Review Comment:
`` works for me because its a reasonable name toda
[
https://issues.apache.org/jira/browse/SOLR-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653623#comment-17653623
]
Jan Høydahl commented on SOLR-16590:
+1 to follw Lucene's lead here. All Java devs wo
[
https://issues.apache.org/jira/browse/SOLR-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653622#comment-17653622
]
Jan Høydahl commented on SOLR-16595:
I see many libraries that use setExpiry(int dura
[
https://issues.apache.org/jira/browse/SOLR-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653618#comment-17653618
]
ASF subversion and git services commented on SOLR-10464:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-10464.
--
Fix Version/s: main (10.0)
9.2
Resolution: Fixed
Finished this migration
> s
[
https://issues.apache.org/jira/browse/SOLR-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653617#comment-17653617
]
ASF subversion and git services commented on SOLR-10464:
Commit f
epugh merged PR #1247:
URL: https://github.com/apache/solr/pull/1247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on code in PR #1247:
URL: https://github.com/apache/solr/pull/1247#discussion_r1060032483
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java:
##
@@ -270,6 +271,17 @@ public Builder withLBHttpSolrClient(LBHttpSolrClient
loadBalanc
noblepaul commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1059974999
##
solr/core/src/test-files/solr/solr.xml:
##
@@ -35,11 +35,6 @@
${connTimeout:15000}
-
Review Comment:
I'm seeing a new pluggable component as follows
noblepaul commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1059974999
##
solr/core/src/test-files/solr/solr.xml:
##
@@ -35,11 +35,6 @@
${connTimeout:15000}
-
Review Comment:
I'm seeing a new pluggable component as follows
janhoy commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1059953698
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/ClosableTracerShim.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
janhoy commented on PR #1168:
URL: https://github.com/apache/solr/pull/1168#issuecomment-1368824084
Happy New Year!
I updated this PR with an integration test similar to the one in
`JaegerTracerConfigurator`, starting the tracer in a cluster.
I then discovered that the OTEL tr
75 matches
Mail list logo
