noblepaul commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1060317489


##########
solr/core/src/test-files/solr/solr.xml:
##########
@@ -35,11 +35,6 @@
     <int name="connTimeout">${connTimeout:15000}</int>
   </shardHandlerFactory>
 
-  <transientCoreCacheFactory name="transientCoreCacheFactory" 
class="TransientSolrCoreCacheFactoryDefault">

Review Comment:
   As we are making `SolrCores` pluggable, we need to clearly define the 
following in JIRA itself: 
   
   - the responsibilities of the plugin
   - the configuration of the plugin
   
   > I'm thinking this is so expert that we shouldn't really say anything about 
it in the ref guide.
   
   It doesn't need to go in ref-guide. But the JIRA may have the definitions
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to