noblepaul commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1059974999
##########
solr/core/src/test-files/solr/solr.xml:
##########
@@ -35,11 +35,6 @@
<int name="connTimeout">${connTimeout:15000}</int>
</shardHandlerFactory>
- <transientCoreCacheFactory name="transientCoreCacheFactory"
class="TransientSolrCoreCacheFactoryDefault">
Review Comment:
I'm seeing a new pluggable component as follows
```
<solrCores class="org.apache.solr.core.TransientSolrCores">
<int name="transientCacheSize">4</int>
</solrCores>
```
The name ` <solrCores>` actually doesn't make any sense. It would need a
more descriptive name say `<coreFactory>` , `<coreManager>` or something like
that
The ticket doesn't even say that you are introducing a new type of component
, what the configuration looks like or what the responsibilities are for that
component type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
