[jira] [Comment Edited] (SOLR-16243) Compile SQL to a Streaming Expression while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551738#comment-17551738 ] Joel Bernstein edited comment on SOLR-16243 at 6/9/22 2:03 AM:

[jira] [Comment Edited] (SOLR-16243) Compile SQL to a Streaming Expression while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551737#comment-17551737 ] Joel Bernstein edited comment on SOLR-16243 at 6/9/22 1:58 AM:

[jira] [Updated] (SOLR-16241) JettyConfig.builder(JettyConfig) misses some properties

2022-06-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-16241: -- Attachment: SOLR-16241.patch Assignee: Chris M. Hostetter Status: Open (w

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-06-08 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551797#comment-17551797 ] Gus Heck commented on SOLR-14699: - Maybe rather than dispense with the separation, just t

[jira] [Comment Edited] (SOLR-16218) failOnVersionConflicts not working on in-place updates

2022-06-08 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551777#comment-17551777 ] Lamine edited comment on SOLR-16218 at 6/8/22 8:31 PM: --- Hi [~ichatt

[jira] [Commented] (SOLR-16218) failOnVersionConflicts not working on in-place updates

2022-06-08 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551777#comment-17551777 ] Lamine commented on SOLR-16218: --- Hi [~ichattopadhyaya], pushed a fix (GitHub PR #898 link a

[jira] [Updated] (SOLR-16218) failOnVersionConflicts not working on in-place updates

2022-06-08 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16218: -- Description:   *Description* Fix a bug in in-place update when _failOnVersionConflicts_=false. When sending i

[GitHub] [solr] dsmiley commented on a diff in pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-06-08 Thread GitBox
dsmiley commented on code in PR #882: URL: https://github.com/apache/solr/pull/882#discussion_r892805323 ## solr/core/src/java/org/apache/solr/util/SolrLogPostTool.java: ## @@ -278,48 +279,71 @@ private void parseError(SolrInputDocument lineRecord, String line, String trace)

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-06-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551757#comment-17551757 ] David Smiley commented on SOLR-14699: - I think JsonTemplateLayout is a distraction to

[jira] [Comment Edited] (SOLR-16243) Compile SQL to a Streaming Expression while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551738#comment-17551738 ] Joel Bernstein edited comment on SOLR-16243 at 6/8/22 6:27 PM:

[jira] [Commented] (SOLR-16243) Compile SQL to a Streaming Expression while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551738#comment-17551738 ] Joel Bernstein commented on SOLR-16243: --- Notice that current implementor only works

[jira] [Commented] (SOLR-16243) Compile SQL to a Streaming Expression while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551737#comment-17551737 ] Joel Bernstein commented on SOLR-16243: --- The current implementor is really only des

[GitHub] [solr] joel-bernstein opened a new pull request, #899: SOLR-16243: Compile SQL to a Streaming Expression while visiting the …

2022-06-08 Thread GitBox
joel-bernstein opened a new pull request, #899: URL: https://github.com/apache/solr/pull/899 …Calcite SQL parse tree https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull

[GitHub] [solr] laminelam opened a new pull request, #898: Fix bug in in-place update when failOnVersionConflicts=false

2022-06-08 Thread GitBox
laminelam opened a new pull request, #898: URL: https://github.com/apache/solr/pull/898 https://issues.apache.org/jira/browse/SOLR-16218 # Description Fix a bug in in-place update when _failOnVersionConflicts_=false. When sending in-place/atomic updates for a non-existen

[GitHub] [solr-operator] janhoy commented on issue #428: Default to port 2181 for zookeeper connection string

2022-06-08 Thread GitBox
janhoy commented on issue #428: URL: https://github.com/apache/solr-operator/issues/428#issuecomment-1150166295 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Updated] (SOLR-16243) Compile SQL to a Streaming Expression while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-16243: -- Description: Currently Solr SQL visits the SQL parse tree and builds up a set of properties th

[jira] [Assigned] (SOLR-16243) Compile SQL to a Streaming Expression while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein reassigned SOLR-16243: - Assignee: Joel Bernstein > Compile SQL to a Streaming Expression while visiting the Calc

[GitHub] [solr-operator] HoustonPutman merged pull request #429: Allow ZkConnectionStrings without ports, log when statefulset is skipped

2022-06-08 Thread GitBox
HoustonPutman merged PR #429: URL: https://github.com/apache/solr-operator/pull/429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr-operator] HoustonPutman closed issue #428: Default to port 2181 for zookeeper connection string

2022-06-08 Thread GitBox
HoustonPutman closed issue #428: Default to port 2181 for zookeeper connection string URL: https://github.com/apache/solr-operator/issues/428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Assigned] (SOLR-16244) Fix typos in unit tests

2022-06-08 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16244: Assignee: Eric Pugh > Fix typos in unit tests > --- > > Key: S

[GitHub] [solr] HoustonPutman commented on pull request #894: SOLR-16236: Clarify use of GSON jar in jaegertracer-configurator

2022-06-08 Thread GitBox
HoustonPutman commented on PR #894: URL: https://github.com/apache/solr/pull/894#issuecomment-1150044699 We already rely on it in other contribs, so I see no harm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Commented] (SOLR-16243) Compile SQL to a Streaming Expression while visiting the Calcite SQL parse tree

2022-06-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551659#comment-17551659 ] Kevin Risden commented on SOLR-16243: - [~jbernste] is this actually the best approach

[jira] [Created] (SOLR-16244) Fix typos in unit tests

2022-06-08 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16244: Summary: Fix typos in unit tests Key: SOLR-16244 URL: https://issues.apache.org/jira/browse/SOLR-16244 Project: Solr Issue Type: Sub-task Security Level: Publi

[jira] [Resolved] (SOLR-16223) Eliminate exceptions that aren't actually thrown

2022-06-08 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16223. -- Fix Version/s: 9.1 main (10.0) Resolution: Fixed > Eliminate exceptions that

[jira] [Commented] (SOLR-16223) Eliminate exceptions that aren't actually thrown

2022-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551654#comment-17551654 ] ASF subversion and git services commented on SOLR-16223: Commit f

[jira] [Updated] (SOLR-16243) Compile SQL to a Streaming Expression while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-16243: -- Summary: Compile SQL to a Streaming Expression while visiting the Calcite SQL parse tree (was:

[jira] [Commented] (SOLR-16223) Eliminate exceptions that aren't actually thrown

2022-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551655#comment-17551655 ] ASF subversion and git services commented on SOLR-16223: Commit 1

[jira] [Comment Edited] (SOLR-16243) Compile SQL to a Streaming Expressions while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551609#comment-17551609 ] Joel Bernstein edited comment on SOLR-16243 at 6/8/22 2:40 PM:

[GitHub] [solr] janhoy commented on pull request #894: SOLR-16236: Clarify use of GSON jar in jaegertracer-configurator

2022-06-08 Thread GitBox
janhoy commented on PR #894: URL: https://github.com/apache/solr/pull/894#issuecomment-1149991915 I vote for keeping gson in the distro, making sure that even "remote" sampling works for all users. Seems quite useful in large deploys according to this blog: https://medium.com/jaegertracing

[jira] [Comment Edited] (SOLR-16243) Compile SQL to a Streaming Expressions while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551609#comment-17551609 ] Joel Bernstein edited comment on SOLR-16243 at 6/8/22 1:08 PM:

[jira] [Comment Edited] (SOLR-16243) Compile SQL to a Streaming Expressions while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551609#comment-17551609 ] Joel Bernstein edited comment on SOLR-16243 at 6/8/22 1:01 PM:

[jira] [Comment Edited] (SOLR-16243) Compile SQL to a Streaming Expressions while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551609#comment-17551609 ] Joel Bernstein edited comment on SOLR-16243 at 6/8/22 12:59 PM: ---

[jira] [Commented] (SOLR-16243) Compile SQL to a Streaming Expressions while visiting the Calcite SQL parse tree

2022-06-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551609#comment-17551609 ] Joel Bernstein commented on SOLR-16243: --- There are three types of nodes in the par

[GitHub] [solr] epugh commented on pull request #894: SOLR-16236: Clarify use of GSON jar in jaegertracer-configurator

2022-06-08 Thread GitBox
epugh commented on PR #894: URL: https://github.com/apache/solr/pull/894#issuecomment-1149858265 Thoughts folks? I kind of need a tie breaker to decide which way to go... I'd like to merge this sooner versus later as I'm accumulating more "pending PR's to get to done" then I like ;-)

[GitHub] [solr] epugh commented on a diff in pull request #897: SOLR-15738: Convert v2 security APIs to annotations

2022-06-08 Thread GitBox
epugh commented on code in PR #897: URL: https://github.com/apache/solr/pull/897#discussion_r892296044 ## solr/core/src/java/org/apache/solr/handler/admin/api/GetAuthenticationConfigAPI.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Resolved] (SOLR-15740) Rewrite v2 schema APIs using annotation framework

2022-06-08 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-15740. Fix Version/s: 9.1 main (10.0) Resolution: Fixed > Rewrite v2 sch

[jira] [Commented] (SOLR-15740) Rewrite v2 schema APIs using annotation framework

2022-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551539#comment-17551539 ] ASF subversion and git services commented on SOLR-15740: Commit 2

[jira] [Commented] (SOLR-15740) Rewrite v2 schema APIs using annotation framework

2022-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551537#comment-17551537 ] ASF subversion and git services commented on SOLR-15740: Commit a

[GitHub] [solr] gerlowskija merged pull request #896: SOLR-15740: Convert v2 schema-edit APIs to annotations

2022-06-08 Thread GitBox
gerlowskija merged PR #896: URL: https://github.com/apache/solr/pull/896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Resolved] (SOLR-15743) Rewrite v2 config APIs using annotation framework

2022-06-08 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-15743. Fix Version/s: 9.1 main (10.0) Resolution: Fixed > Rewrite v2 con

[jira] [Commented] (SOLR-15743) Rewrite v2 config APIs using annotation framework

2022-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551530#comment-17551530 ] ASF subversion and git services commented on SOLR-15743: Commit d

[jira] [Commented] (SOLR-15743) Rewrite v2 config APIs using annotation framework

2022-06-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551523#comment-17551523 ] ASF subversion and git services commented on SOLR-15743: Commit a

[GitHub] [solr] gerlowskija merged pull request #895: SOLR-15743: Convert v2 POST /config APIs to annotations

2022-06-08 Thread GitBox
gerlowskija merged PR #895: URL: https://github.com/apache/solr/pull/895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-06-08 Thread Nazerke Seidan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551515#comment-17551515 ] Nazerke Seidan commented on SOLR-14699: --- I think they are logged only as string in

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-06-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551505#comment-17551505 ] Jan Høydahl commented on SOLR-14699: Are we currently logging "path", "params", "stat

[jira] [Comment Edited] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-06-08 Thread Nazerke Seidan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551500#comment-17551500 ] Nazerke Seidan edited comment on SOLR-14699 at 6/8/22 9:25 AM:

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-06-08 Thread Nazerke Seidan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551500#comment-17551500 ] Nazerke Seidan commented on SOLR-14699: --- if the concern is about extracting MDC val

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-06-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551491#comment-17551491 ] Jan Høydahl commented on SOLR-14699: I see that you, with PatternLayout logging, will

[GitHub] [solr] NazerkeBS commented on a diff in pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-06-08 Thread GitBox
NazerkeBS commented on code in PR #882: URL: https://github.com/apache/solr/pull/882#discussion_r892086497 ## solr/core/src/java/org/apache/solr/util/SolrLogPostTool.java: ## @@ -278,48 +279,72 @@ private void parseError(SolrInputDocument lineRecord, String line, String trace)

[GitHub] [solr] NazerkeBS commented on a diff in pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-06-08 Thread GitBox
NazerkeBS commented on code in PR #882: URL: https://github.com/apache/solr/pull/882#discussion_r892073100 ## solr/core/src/java/org/apache/solr/util/SolrLogPostTool.java: ## @@ -278,48 +279,72 @@ private void parseError(SolrInputDocument lineRecord, String line, String trace)

[jira] [Commented] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-06-08 Thread Marco (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551441#comment-17551441 ] Marco commented on SOLR-16230: -- I have found an alternative solution, that instructs keycloa

[jira] [Updated] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-06-08 Thread Marco (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco updated SOLR-16230: - Attachment: image-2022-06-08-09-28-22-021.png > JWT-Auth: Support for Keycloak-Style nested roles > -

[GitHub] [solr-sandbox] anshumg merged pull request #21: Allow central config from ZK and build updates.

2022-06-08 Thread GitBox
anshumg merged PR #21: URL: https://github.com/apache/solr-sandbox/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach