[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551505#comment-17551505 ]
Jan Høydahl commented on SOLR-14699: ------------------------------------ Are we currently logging "path", "params", "status" and "qtime" in the MDC map, or only as string in the main message? My concern was how simple it would be for the average Solr user to switch to JsonTemplateLayout and be able to pull these custom fields out from the resulting JSON log line without manually deciphering the message string. > Solr request logs should escape names, values > (SolrQueryResponse.getToLogAsString) > ---------------------------------------------------------------------------------- > > Key: SOLR-14699 > URL: https://issues.apache.org/jira/browse/SOLR-14699 > Project: Solr > Issue Type: Improvement > Components: logging > Reporter: David Smiley > Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > {{SolrQueryResponse.getToLogAsString}} encodes the NamedList into a String > with simple space-separated pairs with name=value. However, it does no > escaping/encoding, and as-such a value might itself contain spaces and > equals. This is a problem if these logs are being parsed, and we'd like to > ensure we do so correctly. Note that SolrLogPostTool (aka "postlogs") parses > these logs. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org