[
https://issues.apache.org/jira/browse/SOLR-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551738#comment-17551738
]
Joel Bernstein edited comment on SOLR-16243 at 6/9/22 2:03 AM:
---------------------------------------------------------------
Notice the current implementor only works for one query:
https://github.com/apache/solr/blob/03efd00a4fe2b5f946cf539c3ef831ff55d4f07b/solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrRel.java#L38
You could have a SolrLogicalJoin create two implementors but it would get very
messy here:
https://github.com/apache/solr/blob/03efd00a4fe2b5f946cf539c3ef831ff55d4f07b/solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrToEnumerableConverter.java#L54
If we create the Streaming Expression while walking the Calcite parse tree we
can send a fully formed Streaming Expression to the SolrTable.
was (Author: joel.bernstein):
Notice the current implementor only works for one query:
https://github.com/apache/solr/blob/03efd00a4fe2b5f946cf539c3ef831ff55d4f07b/solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrRel.java#L38
> Compile SQL to a Streaming Expression while visiting the Calcite SQL parse
> tree
> -------------------------------------------------------------------------------
>
> Key: SOLR-16243
> URL: https://issues.apache.org/jira/browse/SOLR-16243
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Parallel SQL
> Reporter: Joel Bernstein
> Assignee: Joel Bernstein
> Priority: Major
> Labels: RobustSQL
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently Solr SQL visits the SQL parse tree and builds up a set of
> properties that are passed to the SolrTable which creates the Streaming
> Expression object tree. This technique only works because we're not dealing
> yet with joins. It won't be practical to express joins using the current
> approach. In order to support joins we'll need to build the Streaming
> Expression as we visit the parse tree and pass the expression directly to the
> SolrTable.
> This ticket will only implement existing SQL support using the direct
> compilation approach.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
