dsmiley opened a new pull request #629:
URL: https://github.com/apache/solr/pull/629
https://issues.apache.org/jira/browse/SOLR-15064
Thankfully I left a number of hints back when this hack was added so that it
wasn't hard to remove the substance of the change. The real work was upd
[
https://issues.apache.org/jira/browse/SOLR-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491256#comment-17491256
]
ASF subversion and git services commented on SOLR-15974:
Commit 6
thelabdude merged pull request #628:
URL: https://github.com/apache/solr/pull/628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
thelabdude opened a new pull request #628:
URL: https://github.com/apache/solr/pull/628
backport of https://github.com/apache/solr/pull/626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
[
https://issues.apache.org/jira/browse/SOLR-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491240#comment-17491240
]
ASF subversion and git services commented on SOLR-15974:
Commit 5
thelabdude merged pull request #627:
URL: https://github.com/apache/solr/pull/627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
dsmiley commented on pull request #601:
URL: https://github.com/apache/solr/pull/601#issuecomment-1036934788
I found the lifecycle of these "proc" instances in this code to not be as
clear as I'd like. And I saw that finish() was being called after each
document (when parallel replay) whi
thelabdude opened a new pull request #627:
URL: https://github.com/apache/solr/pull/627
https://issues.apache.org/jira/browse/SOLR-15974
backport of https://github.com/apache/solr/pull/626
# Description
Please provide a short description of the changes you're
[
https://issues.apache.org/jira/browse/SOLR-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491227#comment-17491227
]
ASF subversion and git services commented on SOLR-15974:
Commit 7
thelabdude merged pull request #626:
URL: https://github.com/apache/solr/pull/626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/SOLR-16006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491178#comment-17491178
]
Kevin Risden commented on SOLR-16006:
-
I've been slowly playing with these to try to
[
https://issues.apache.org/jira/browse/SOLR-15257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491177#comment-17491177
]
ASF subversion and git services commented on SOLR-15257:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-16006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned SOLR-16006:
---
Assignee: Kevin Risden
> Audit declared/unused dependencies
> --
[
https://issues.apache.org/jira/browse/SOLR-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491176#comment-17491176
]
ASF subversion and git services commented on SOLR-12336:
Commit e
madrob merged pull request #529:
URL: https://github.com/apache/solr/pull/529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
[
https://issues.apache.org/jira/browse/SOLR-16006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491175#comment-17491175
]
Kevin Risden commented on SOLR-16006:
-
FWIW a bunch of these are addressed in SOLR-15
Mike Drob created SOLR-16006:
Summary: Audit declared/unused dependencies
Key: SOLR-16006
URL: https://issues.apache.org/jira/browse/SOLR-16006
Project: Solr
Issue Type: Task
Reporter
thelabdude opened a new pull request #626:
URL: https://github.com/apache/solr/pull/626
https://issues.apache.org/jira/browse/SOLR-15974
Disable the `EnumerableRules.ENUMERABLE_AGGREGATE_RULE` optimization so that
Solr only deals with LogicalAggregate. I looked into adding another ru
HoustonPutman closed issue #405:
URL: https://github.com/apache/solr-operator/issues/405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
HoustonPutman merged pull request #406:
URL: https://github.com/apache/solr-operator/pull/406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issu
janhoy merged pull request #607:
URL: https://github.com/apache/solr/pull/607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
ijioio commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036578775
> How you think, maybe we should do the same trick for delete snapshot also?
I mean adding field startTime (it is not added for some reason) and adding
field endTime to duplicate sna
[
https://issues.apache.org/jira/browse/SOLR-15992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491120#comment-17491120
]
ASF subversion and git services commented on SOLR-15992:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491119#comment-17491119
]
ASF subversion and git services commented on SOLR-15991:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-15432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491125#comment-17491125
]
ASF subversion and git services commented on SOLR-15432:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491116#comment-17491116
]
ASF subversion and git services commented on SOLR-15907:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491117#comment-17491117
]
ASF subversion and git services commented on SOLR-15907:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-15988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491121#comment-17491121
]
ASF subversion and git services commented on SOLR-15988:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-15963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491122#comment-17491122
]
ASF subversion and git services commented on SOLR-15963:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-15987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491118#comment-17491118
]
ASF subversion and git services commented on SOLR-15987:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491124#comment-17491124
]
ASF subversion and git services commented on SOLR-15556:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491123#comment-17491123
]
ASF subversion and git services commented on SOLR-15556:
Commit d
epugh merged pull request #622:
URL: https://github.com/apache/solr/pull/622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@so
Mike Drob created SOLR-16005:
Summary: Admin UI doesn't allow adding schema field types
Key: SOLR-16005
URL: https://issues.apache.org/jira/browse/SOLR-16005
Project: Solr
Issue Type: Task
HoustonPutman commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036534858
Nvm, I think I fixed it. I will push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
HoustonPutman commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036531144
> OMG, it seems I messed up with conflict merge in Eclipse...
It looks like the merge commit swallowed up all the other commits on main...
Try resetting your head
ijioio commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036522198
OMG, it seems I messed up with conflict merge in Eclipse...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
epugh commented on pull request #622:
URL: https://github.com/apache/solr/pull/622#issuecomment-1036521652
> https://github.com/apache/solr/search?q=freenode finds one additional
match on latest `main` it seems.
Awesome thought on how to search!
--
This is an automated message fro
HoustonPutman opened a new pull request #406:
URL: https://github.com/apache/solr-operator/pull/406
Fixes #405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
madrob commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r804920634
##
File path: .github/workflows/manual.yml
##
@@ -0,0 +1,21 @@
+name: Scheduled Merge Remote Action
Review comment:
I don't think we want this? Might be
madrob commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r803126032
##
File path: solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java
##
@@ -631,6 +630,11 @@ public InputStream getStream() throws IOException {
madrob commented on pull request #620:
URL: https://github.com/apache/solr/pull/620#issuecomment-1036512745
> but could mean instead the test loops forever, hmm
Add a check for `timeout.hasTimedOut()`
--
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/SOLR-16004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491088#comment-17491088
]
Michael Gibney commented on SOLR-16004:
---
PR #625 implements support for these. It o
HoustonPutman opened a new issue #405:
URL: https://github.com/apache/solr-operator/issues/405
As of 2022-02-11, these are:
ID | SEVERITY | PACKAGE | VERSION | FIXED IN
-- | -- | -- | -- | --
CVE-2021-3121 | HIGH | github.com/gogo/protobuf | v1.3.1 | 1.3.2
CVE-2020-29
magibney opened a new pull request #625:
URL: https://github.com/apache/solr/pull/625
See: [SOLR-16004](https://issues.apache.org/jira/browse/SOLR-16004)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ijioio commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036502351
@HoustonPutman @cpoerschke
How you think, maybe we should do the same trick for delete snapshot also? I
mean adding field `startTime` (it is not added for some reason) and add
HoustonPutman commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036501713
This looks good to me. Maybe instead of `TODO:` put `DEPRECATED:`, gives a
better indication of future action.
Otherwise I think this is probably good to go once the do
HoustonPutman commented on issue #385:
URL: https://github.com/apache/solr-operator/issues/385#issuecomment-1036499308
No update, I can't really think of any reason this would be failing... The
only thing I can think of is there is something wrong with the Kube cluster,
and that restarting
Michael Gibney created SOLR-16004:
-
Summary: Add support for minShouldMatch and tolerateOtherTerms in
{!terms} TermsQParserPlugin
Key: SOLR-16004
URL: https://issues.apache.org/jira/browse/SOLR-16004
ijioio commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036498290
> I see one in deleteNamedSnapshot() as well.
Updated
> Understood, but I think the best user experience is that people can expect
the same field names for single-shard
HoustonPutman commented on issue #386:
URL: https://github.com/apache/solr-operator/issues/386#issuecomment-1036498001
I think it's a nice feature, and could make it into `v0.6.0` if someone
makes a PR for it. I'm not sure I have time currently, but I doubt `v0.6.0`
will be coming out soon
HoustonPutman merged pull request #398:
URL: https://github.com/apache/solr-operator/pull/398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issu
ijioio commented on a change in pull request #595:
URL: https://github.com/apache/solr/pull/595#discussion_r804897545
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/BackupCmd.java
##
@@ -289,7 +294,10 @@ private void incrementalCopyIndexFiles(URI backup
HoustonPutman commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036481824
> Good catch! I encountered this kind of comment at
org.apache.solr.handler.SnapShooter.createSnapshot(IndexCommit). It seems this
is the only place. Let's update it!
I
cpoerschke commented on a change in pull request #595:
URL: https://github.com/apache/solr/pull/595#discussion_r804884691
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/BackupCmd.java
##
@@ -298,7 +306,7 @@ private void incrementalCopyIndexFiles(URI bac
ijioio commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036465001
@HoustonPutman Thank you for the notes!
> I believe snapshotCompletedAt is a new field, correct? If so why not name
it endTime to match the incremental backup response?
ijioio commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036445656
This is how aggregated result is looks like after changes/suggestions we
discussed above:
For incremental backup:
```json
"response": {
"collection": "
[
https://issues.apache.org/jira/browse/SOLR-14909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-14909:
--
Fix Version/s: (was: main (10.0))
> Add replica is very slow on a large cluster
> -
[
https://issues.apache.org/jira/browse/SOLR-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491040#comment-17491040
]
Houston Putman commented on SOLR-13737:
---
Agreed, this would be great to get in for
[
https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491028#comment-17491028
]
ASF subversion and git services commented on SOLR-15556:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491029#comment-17491029
]
ASF subversion and git services commented on SOLR-15556:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491030#comment-17491030
]
ASF subversion and git services commented on SOLR-15556:
Commit 6
HoustonPutman edited a comment on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036382541
Beyond what Christine has said, I have a few questions:
- I believe `snapshotCompletedAt` is a new field, correct? If so why not
name it `endTime` to match the in
HoustonPutman commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036383929
Ahh just realized that `snapshotCompletedAt` is actually not a new field.
Maybe we add a duplicate field `endTime`, so that we can phase out
`snapshotCompletedAt` in Solr 10?
HoustonPutman commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036382541
Beyond what Christine has said, I have a few questions:
- I believe `snapshotCompletedAt` is a new field, correct? If so why not
name it `endTime` to match the increment
ijioio commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036372884
Hi, @cpoerschke ! Thank you for the comments!
> Could it also be confusing for users to have both indexFileCount and
uploadedIndexFileCount values instead of the one fileCount
[
https://issues.apache.org/jira/browse/SOLR-16002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490971#comment-17490971
]
Michael Gibney commented on SOLR-16002:
---
This is a really minor, straightforward ch
bruno-roustant commented on a change in pull request #608:
URL: https://github.com/apache/solr/pull/608#discussion_r804539688
##
File path: solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java
##
@@ -176,14 +176,18 @@ private SolrIndexWriter(SolrCore core, String name
bruno-roustant commented on a change in pull request #608:
URL: https://github.com/apache/solr/pull/608#discussion_r804738512
##
File path: solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java
##
@@ -176,14 +176,18 @@ private SolrIndexWriter(SolrCore core, String name
[
https://issues.apache.org/jira/browse/SOLR-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490942#comment-17490942
]
Susheel Kumar commented on SOLR-12209:
--
Awesome, Joel. Will try that.
> add Paging
cpoerschke commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036240452
> Second, let's compare shard responses of incremental and snapshot backups:
>
> Incremental:
>
> ```json
> "response": {
> "startTime": "20
cpoerschke commented on pull request #622:
URL: https://github.com/apache/solr/pull/622#issuecomment-1036208225
https://github.com/apache/solr/search?q=freenode finds one additional match
on latest `main` it seems.
--
This is an automated message from the Apache Git Service.
To respond t
cpoerschke commented on pull request #601:
URL: https://github.com/apache/solr/pull/601#issuecomment-1036196947
> This PR isn't clear to me. It appears it would ignore the existing created
`proc` and simply create another. I don't get the point of that. AFAICT, this
method (doReplay) runs
bruno-roustant commented on pull request #608:
URL: https://github.com/apache/solr/pull/608#issuecomment-1036079019
Yes I'm thinking of it just as an internal feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
bruno-roustant commented on a change in pull request #608:
URL: https://github.com/apache/solr/pull/608#discussion_r804540547
##
File path: solr/core/src/java/org/apache/solr/update/CommitUpdateCommand.java
##
@@ -54,6 +57,7 @@ public String toString() {
+",expunge
bruno-roustant commented on a change in pull request #608:
URL: https://github.com/apache/solr/pull/608#discussion_r804539688
##
File path: solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java
##
@@ -176,14 +176,18 @@ private SolrIndexWriter(SolrCore core, String name
[
https://issues.apache.org/jira/browse/SOLR-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15064:
---
Environment: (was: Updating to make a blocker for 9.0 because I
_really_ want to remove the 9.0 h
bruno-roustant commented on a change in pull request #608:
URL: https://github.com/apache/solr/pull/608#discussion_r804447602
##
File path: solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java
##
@@ -176,14 +176,18 @@ private SolrIndexWriter(SolrCore core, String name
78 matches
Mail list logo
