cpoerschke commented on pull request #601: URL: https://github.com/apache/solr/pull/601#issuecomment-1036196947
> This PR isn't clear to me. It appears it would ignore the existing created `proc` and simply create another. I don't get the point of that. AFAICT, this method (doReplay) runs in its own thread (from run()) as well. Yes, the `doReplay` method runs in its own thread but since https://github.com/apache/solr/commit/6084da559c5466551af68c114b7310356c989dec and https://issues.apache.org/jira/browse/SOLR-12338 it can parallelise some of the work via the executor i.e. additional threads; but only some of the work goes to the executor and therefore the existing `proc` continues to be used in the `doReplay` method's thread (and the executor threads get their own `proc` objects). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
