HoustonPutman commented on pull request #595: URL: https://github.com/apache/solr/pull/595#issuecomment-1036481824
> Good catch! I encountered this kind of comment at org.apache.solr.handler.SnapShooter.createSnapshot(IndexCommit). It seems this is the only place. Let's update it! I see one in `deleteNamedSnapshot()` as well. > Yeah, it is not a new field. We doesn't touch shard's responses, only updating aggregated result. I will check out shard response and I think I can add an additional fields endTime to duplicate snapshotCompletedAt. Understood, but I think the best user experience is that people can expect the same field names for single-shard vs multi-shard. So might as well do it in this PR 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
